When trying to break a line after an image followed by some text, contrary to the expected behavior…

When trying to break a line after an image followed by some text, contrary to the expected behavior the text doesn't move to a new line, instead, the caret position just shifts to the end of line.

As per the existing implementation for inserting a paragraph separator,
the insertion position obtained corresponds to the point after the image
element.
Since the insertion position doesn't resolve to being offset in the
following text node (0 offset), no splitting of text occurs and the block
to be inserted is placed after the containing (start) block (thereby
causing the caret position to shift).

If the computed insertionPosition points to an element that shall be
ignored for editing purposes (i.e. cannot have a VisiblePosition inside
it), and the position lies either at the start or at the end of such
an element, we should move our Position either upstream or
downstream (respectively) so as to obtain a valid position which can
be used further for splitting of the text.

Moving the insertionPosition either upstream or downstream, if the point
lies either at the start or at the end of the anchor node.
The ensuing position, if a text node, can then be used for splitting of
the text correctly.

This patch has landed in Webkit: https://trac.webkit.org/changeset/151604

BUG=251209
R=leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153866

[eseidel, 2013-07-10 05:37:10]

Ojan or Rniwa are better reviewers for this than I.  I CC ryosuke as he may be
interested in this for webkit.org's editing as well (and is really the best
expert on this code).

[eseidel, 2013-07-10 05:38:31]

This seems reasonable to me.  so lgtm.  Please give a day or so to allow ojan or
rniwa to confirm before landing.

[arpitab_, 2013-07-10 06:06:34]

On 2013/07/10 05:38:31, eseidel wrote:
> This seems reasonable to me.  so lgtm.  Please give a day or so to allow ojan
or
> rniwa to confirm before landing.

Hi Eric, this patch has already been reviewed by rniwa (in Webkit):
https://trac.webkit.org/changeset/151604

[eseidel, 2013-07-10 06:08:41]

lgtm

[commit-bot: I haz the power, 2013-07-10 06:09:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.bah@samsung.com/17381003/1

[commit-bot: I haz the power, 2013-07-10 08:01:34]

Change committed as 153866