third_party/WebKit/Source/web/InspectorOverlay.h - Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp ('k') | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/InspectorOverlay.h

diff --git a/third_party/WebKit/Source/web/InspectorOverlay.h b/third_party/WebKit/Source/web/InspectorOverlay.h

index 802f4b8dd480bf7cff230743eedd08ea1752f794..c16af67f6ce2766a2b4acad761fcdd12d6de254a 100644

--- a/third_party/WebKit/Source/web/InspectorOverlay.h

+++ b/third_party/WebKit/Source/web/InspectorOverlay.h

@@ -53,13 +53,16 @@ class GraphicsContext;

class GraphicsLayer;

class InspectorCSSAgent;

class InspectorDebuggerAgent;

-class JSONValue;

class LayoutEditor;

class Node;

class Page;

class PageOverlay;

class WebViewImpl;

+namespace protocol {

+class Value;

class InspectorOverlay final

: public NoBaseWillBeGarbageCollectedFinalized<InspectorOverlay>

, public InspectorDOMAgent::Client

@@ -127,7 +130,7 @@ private:

LocalFrame* overlayMainFrame();

void reset(const IntSize& viewportSize, const IntPoint& documentScrollOffset);

void evaluateInOverlay(const String& method, const String& argument);

- void evaluateInOverlay(const String& method, PassRefPtr<JSONValue> argument);

+ void evaluateInOverlay(const String& method, PassRefPtr<protocol::Value> argument);

void onTimer(Timer<InspectorOverlay>*);

void rebuildOverlayPage();

void invalidate();