Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6604)

Unified Diff: chrome/installer/setup/installer_metrics.cc

Issue 1738063002: Refactor histogram_persistence to be a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed final review comments by Alexei Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_field_trials.cc ('k') | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/installer_metrics.cc
diff --git a/chrome/installer/setup/installer_metrics.cc b/chrome/installer/setup/installer_metrics.cc
index 8e5f0443e437f7589493be0818c56ef397cf2b17..5bf860ced29b3c91050db9928e21e0ef669d8075 100644
--- a/chrome/installer/setup/installer_metrics.cc
+++ b/chrome/installer/setup/installer_metrics.cc
@@ -8,29 +8,29 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/metrics/histogram_base.h"
-#include "base/metrics/histogram_persistence.h"
+#include "base/metrics/persistent_histogram_allocator.h"
#include "base/metrics/persistent_memory_allocator.h"
#include "chrome/installer/util/util_constants.h"
namespace installer {
void BeginPersistentHistogramStorage() {
- base::SetPersistentHistogramMemoryAllocator(
- new base::LocalPersistentMemoryAllocator(
- 1 << 20, 0, // 1 MiB
- installer::kSetupHistogramAllocatorName));
- base::GetPersistentHistogramMemoryAllocator()->CreateTrackingHistograms(
+ base::PersistentHistogramAllocator::CreateGlobalAllocatorOnLocalMemory(
+ 1 << 20, // 1 MiB
+ 0, // No identifier.
installer::kSetupHistogramAllocatorName);
+ base::PersistentHistogramAllocator::GetGlobalAllocator()
+ ->CreateTrackingHistograms(installer::kSetupHistogramAllocatorName);
}
void EndPersistentHistogramStorage(const base::FilePath& target_path) {
+ base::PersistentHistogramAllocator* allocator =
+ base::PersistentHistogramAllocator::GetGlobalAllocator();
+ allocator->UpdateTrackingHistograms();
+
// For atomicity, first write to a temporary file and then rename it.
// The ImportantFileWriter would be good for this except it supports only
// std::string for its data.
- base::PersistentMemoryAllocator* allocator =
- base::GetPersistentHistogramMemoryAllocator();
- allocator->UpdateTrackingHistograms();
-
base::FilePath file_path = target_path
.AppendASCII(allocator->Name())
.AddExtension(L".pma");
« no previous file with comments | « chrome/browser/chrome_browser_field_trials.cc ('k') | components/metrics/file_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698