Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5078)

Unified Diff: chrome/browser/chrome_browser_field_trials.cc

Issue 1738063002: Refactor histogram_persistence to be a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move some parameters up a line Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_field_trials.cc
diff --git a/chrome/browser/chrome_browser_field_trials.cc b/chrome/browser/chrome_browser_field_trials.cc
index 682271f04904f4c105a633e168a60741ceeeff5f..2696ff0b0ff1c5ed001597f2d2047ed8dc3ac15e 100644
--- a/chrome/browser/chrome_browser_field_trials.cc
+++ b/chrome/browser/chrome_browser_field_trials.cc
@@ -10,7 +10,7 @@
#include "base/feature_list.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram_base.h"
-#include "base/metrics/histogram_persistence.h"
+#include "base/metrics/persistent_histogram_allocator.h"
#include "base/strings/string_util.h"
#include "base/time/time.h"
#include "build/build_config.h"
@@ -33,12 +33,12 @@ void InstantiatePersistentHistograms() {
// Create persistent/shared memory and allow histograms to be stored in it.
// Memory that is not actualy used won't be physically mapped by the system.
// BrowserMetrics usage peaked around 95% of 2MiB as of 2016-02-20.
- base::SetPersistentHistogramMemoryAllocator(
- new base::LocalPersistentMemoryAllocator(3 << 20, // 3 MiB
- 0x935DDD43, // SHA1(B...M...)
- kAllocatorName));
- base::GetPersistentHistogramMemoryAllocator()->CreateTrackingHistograms(
+ base::PersistentHistogramAllocator::CreateGlobalAllocatorOnLocalMemory(
+ 3 << 20, // 3 MiB
+ 0x935DDD43, // SHA1(BrowserMetrics)
kAllocatorName);
+ base::PersistentHistogramAllocator::GetGlobalAllocator()
+ ->CreateTrackingHistograms(kAllocatorName);
}
}

Powered by Google App Engine
This is Rietveld 408576698