Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: content/public/browser/render_widget_host_view.h

Issue 173803002: Redesigns the text input focus handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments from sky. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_widget_host_view.h
diff --git a/content/public/browser/render_widget_host_view.h b/content/public/browser/render_widget_host_view.h
index 4c0df76ac21e17c3da87a3a86cd3d21dc9642047..7638a2e76d72f0e679af6ad59c1bb807a6d05dfe 100644
--- a/content/public/browser/render_widget_host_view.h
+++ b/content/public/browser/render_widget_host_view.h
@@ -20,6 +20,10 @@ class Rect;
class Size;
}
+namespace ui {
+class TextInputClient;
+}
+
namespace content {
class BrowserAccessibilityManager;
@@ -76,6 +80,13 @@ class CONTENT_EXPORT RenderWidgetHostView {
virtual gfx::NativeViewId GetNativeViewId() const = 0;
virtual gfx::NativeViewAccessible GetNativeViewAccessible() = 0;
+ // Returns a ui::TextInputClient to support text input or NULL if this RWHV
+ // doesn't support text input.
+ // Note: Not all the platforms use ui::InputMethod and ui::TextInputClient for
+ // text input. Some of platforms (Mac and Android for example) use their own
msw 2014/05/02 18:46:03 nit: "Some platforms" or "Some of the platforms"
Yuki 2014/05/07 05:58:02 Done.
+ // text input system.
+ virtual ui::TextInputClient* GetTextInputClient() = 0;
+
// Set focus to the associated View component.
virtual void Focus() = 0;
// Returns true if the View currently has the focus.

Powered by Google App Engine
This is Rietveld 408576698