content/browser/renderer_host/render_widget_host_view_base.cc - Issue 173803002: Redesigns the text input focus handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 173803002: Redesigns the text input focus handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments from msw. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index 197960fed6152762e78077f530c6f6d935f43dc3..0aad9dc699f203d53d884ab0dbb2bc99c927d71f 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -425,6 +425,11 @@ void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text,

selection_range_.set_end(range.end());

}

+ui::TextInputClient* RenderWidgetHostViewBase::GetTextInputClient() {

+ NOTREACHED();

+ return NULL;

bool RenderWidgetHostViewBase::IsShowingContextMenu() const {

return showing_context_menu_;

}