Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: ui/views/widget/desktop_aura/x11_desktop_handler.cc

Issue 173803002: Redesigns the text input focus handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added an unittest and thread checker. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/x11_desktop_handler.cc
diff --git a/ui/views/widget/desktop_aura/x11_desktop_handler.cc b/ui/views/widget/desktop_aura/x11_desktop_handler.cc
index 170b5f790cc6527891f16783ffe2db33248f1aef..c166d2d592d712f06a313b2a0c0393060b8d6cbd 100644
--- a/ui/views/widget/desktop_aura/x11_desktop_handler.cc
+++ b/ui/views/widget/desktop_aura/x11_desktop_handler.cc
@@ -189,12 +189,13 @@ void X11DesktopHandler::OnActiveWindowChanged(::Window xid) {
if (old_host)
old_host->HandleNativeWidgetActivationChanged(false);
+ // Update the current window ID to effectively change the active widget.
+ current_window_ = xid;
msw 2014/04/18 19:57:57 Can you explain why this change is needed for this
Yuki 2014/04/22 09:09:02 It's because we have to change the active widget b
+
DesktopWindowTreeHostX11* new_host =
views::DesktopWindowTreeHostX11::GetHostForXID(xid);
if (new_host)
new_host->HandleNativeWidgetActivationChanged(true);
-
- current_window_ = xid;
}
} // namespace views

Powered by Google App Engine
This is Rietveld 408576698