Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: ui/views/focus/focus_manager.h

Issue 173803002: Redesigns the text input focus handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/focus/focus_manager.h
diff --git a/ui/views/focus/focus_manager.h b/ui/views/focus/focus_manager.h
index 7d7c7dc16e02454ede26733b6d93178a823eda67..60ae226b8c9787c68dde3ddfad980a085487bd79 100644
--- a/ui/views/focus/focus_manager.h
+++ b/ui/views/focus/focus_manager.h
@@ -72,8 +72,8 @@
// is FocusTraversable.
namespace ui {
-class AcceleratorTarget;
class AcceleratorManager;
+class AcceleratorTarget;
class EventHandler;
class KeyEvent;
}
@@ -156,6 +156,11 @@ class VIEWS_EXPORT FocusManager {
// further.
bool OnKeyEvent(const ui::KeyEvent& event);
+ // Changes the text input focus to |view->GetTextInputClient()| iff |view|
+ // is focused. Views must call this method when their internal
+ // TextInputClient instance changes.
+ void OnTextInputClientChanged(View* view);
+
// Returns true is the specified is part of the hierarchy of the window
// associated with this FocusManager.
bool ContainsView(View* view);
@@ -213,6 +218,10 @@ class VIEWS_EXPORT FocusManager {
// Returns true if in the process of changing the focused view.
bool is_changing_focus() const { return is_changing_focus_; }
+ // Moves the text input focus into/out from |view|.
msw 2014/03/12 20:56:15 nit: now that these are public, group them with On
Yuki 2014/03/14 15:25:22 Done.
+ void FocusTextInputClient(View* view);
+ void BlurTextInputClient(View* view);
+
// Disable shortcut handling.
static void set_shortcut_handling_suspended(bool suspended) {
shortcut_handling_suspended_ = suspended;

Powered by Google App Engine
This is Rietveld 408576698