Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: ui/views/widget/desktop_aura/x11_desktop_handler.cc

Issue 173803002: Redesigns the text input focus handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/x11_desktop_handler.cc
diff --git a/ui/views/widget/desktop_aura/x11_desktop_handler.cc b/ui/views/widget/desktop_aura/x11_desktop_handler.cc
index d98dfa644354d2590d7e42c20e4eb52eaa68fdd2..3995d5846d8e549981cbb5d06109ad47b23cc881 100644
--- a/ui/views/widget/desktop_aura/x11_desktop_handler.cc
+++ b/ui/views/widget/desktop_aura/x11_desktop_handler.cc
@@ -186,12 +186,14 @@ void X11DesktopHandler::OnActiveWindowChanged(::Window xid) {
if (old_host)
old_host->HandleNativeWidgetActivationChanged(false);
+ // Set a new window id. This effectively changes the active widget to the new
msw 2014/03/11 23:24:39 nit: consider "Update the current window ID to eff
Yuki 2014/03/12 09:13:15 Done.
+ // window.
+ current_window_ = xid;
+
DesktopWindowTreeHostX11* new_host =
views::DesktopWindowTreeHostX11::GetHostForXID(xid);
if (new_host)
new_host->HandleNativeWidgetActivationChanged(true);
-
- current_window_ = xid;
}
::Window X11DesktopHandler::GetNextToActivateInStack(

Powered by Google App Engine
This is Rietveld 408576698