Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: ui/base/ime/input_method_base.cc

Issue 173803002: Redesigns the text input focus handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_base.cc
diff --git a/ui/base/ime/input_method_base.cc b/ui/base/ime/input_method_base.cc
index d3b561cf78ed80f8bc7e889030a82a73fa187b23..3b5428dd6255d7bfac95f76ab9234b8a2f5ff689 100644
--- a/ui/base/ime/input_method_base.cc
+++ b/ui/base/ime/input_method_base.cc
@@ -10,6 +10,8 @@
#include "ui/base/ime/input_method_delegate.h"
#include "ui/base/ime/input_method_observer.h"
#include "ui/base/ime/text_input_client.h"
+#include "ui/base/ime/text_input_focus_manager.h"
+#include "ui/base/ui_base_switches_util.h"
#include "ui/events/event.h"
namespace ui {
@@ -56,6 +58,9 @@ void InputMethodBase::DetachTextInputClient(TextInputClient* client) {
}
TextInputClient* InputMethodBase::GetTextInputClient() const {
+ if (switches::IsNewTextInputFocusEnabled())
+ return TextInputFocusManager::GetInstance()->GetFocusedTextInputClient();
+
return system_toplevel_window_focused_ ? text_input_client_ : NULL;
}
@@ -123,6 +128,9 @@ void InputMethodBase::NotifyTextInputStateChanged(
void InputMethodBase::SetFocusedTextInputClientInternal(
TextInputClient* client) {
+ if (switches::IsNewTextInputFocusEnabled())
+ return;
msw 2014/03/11 00:58:50 Will the input methods still work okay without cal
Yuki 2014/03/11 15:27:37 It's okay. views::FocusManager::{Focus,Blur}TextI
msw 2014/03/11 23:24:37 Sounds good.
+
TextInputClient* old = text_input_client_;
if (old == client)
return;

Powered by Google App Engine
This is Rietveld 408576698