ChromeOS: Add RenameCryptohome and migration code.

ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual

Committed: https://crrev.com/ad238d39cab83b2c09094a2f769e603bedb40e54
Cr-Commit-Position: refs/heads/master@{#380253}

[Alexander Alekseev, 2016-02-26 02:53:50]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[Alexander Alekseev, 2016-02-26 02:54:59]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Alexander Alekseev, 2016-02-26 02:54:59]

Please review.

[commit-bot: I haz the power, 2016-02-26 02:56:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738023002/1

[commit-bot: I haz the power, 2016-02-26 03:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 03:16:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[stevenjb, 2016-02-26 16:48:20]

Thanks for splitting this up.

Please have someone familiar with cryptohome also review this.

https://codereview.chromium.org/1738023002/diff/1/chromeos/login/auth/cryptoh...
File chromeos/login/auth/cryptohome_authenticator.cc (right):

https://codereview.chromium.org/1738023002/diff/1/chromeos/login/auth/cryptoh...
chromeos/login/auth/cryptohome_authenticator.cc:177: DoMount(attempt, resolver,
ephemeral, create_if_nonexistent);
Do we still want to call DoMount on failure? If so, please add a comment at the
bottom of the 'else' clause.

[Alexander Alekseev, 2016-03-04 10:32:48]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 10:32:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738023002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738023002/60001

[commit-bot: I haz the power, 2016-03-04 10:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 10:42:07]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Alekseev, 2016-03-05 00:50:25]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-05 00:50:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738023002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738023002/80001

[Alexander Alekseev, 2016-03-05 00:58:25]

alemate@chromium.org changed reviewers:
+ dkrahn@google.com, isherman@chromium.org

[Alexander Alekseev, 2016-03-05 00:58:26]

+dkrahn@:
  chromeos/dbus/*

+isherman@:
  tools/metrics/histograms.xml

The only difference of chromeos/dbus/* against previous
https://codereview.chromium.org/1693383003 is the addition of UMA metrics.

Please review.

https://codereview.chromium.org/1738023002/diff/1/chromeos/login/auth/cryptoh...
File chromeos/login/auth/cryptohome_authenticator.cc (right):

https://codereview.chromium.org/1738023002/diff/1/chromeos/login/auth/cryptoh...
chromeos/login/auth/cryptohome_authenticator.cc:177: DoMount(attempt, resolver,
ephemeral, create_if_nonexistent);
On 2016/02/26 16:48:20, stevenjb wrote:
> Do we still want to call DoMount on failure? If so, please add a comment at
the
> bottom of the 'else' clause.

Done.

[Ilya Sherman, 2016-03-05 01:08:05]

https://codereview.chromium.org/1738023002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1738023002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:14942: +<histogram
name="GaiaId.Migration.Cryptohome" enum="GaiaIdMigrationCryptohome">
Please use the existing top-level name "Cryptohome" as the prefix for this
histogram name.

https://codereview.chromium.org/1738023002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:14944: +  <summary>This is the status of
cryptohome migration to GaiaId.</summary>
Please document when this is recorded.

[Alexander Alekseev, 2016-03-05 01:33:45]

https://codereview.chromium.org/1738023002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1738023002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:14942: +<histogram
name="GaiaId.Migration.Cryptohome" enum="GaiaIdMigrationCryptohome">
On 2016/03/05 01:08:05, Ilya Sherman wrote:
> Please use the existing top-level name "Cryptohome" as the prefix for this
> histogram name.

Done.

https://codereview.chromium.org/1738023002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:14944: +  <summary>This is the status of
cryptohome migration to GaiaId.</summary>
On 2016/03/05 01:08:05, Ilya Sherman wrote:
> Please document when this is recorded.

Done.

[Ilya Sherman, 2016-03-05 10:09:27]

metrics lgtm

[stevenjb, 2016-03-07 17:56:34]

lgtm

https://codereview.chromium.org/1738023002/diff/100001/chromeos/login/auth/cr...
File chromeos/login/auth/cryptohome_authenticator.cc (right):

https://codereview.chromium.org/1738023002/diff/100001/chromeos/login/auth/cr...
chromeos/login/auth/cryptohome_authenticator.cc:258:
CryptohomeMigrationToGaiaId::ALREADY_MIGRATED);
nit: {}

[Alexander Alekseev, 2016-03-09 01:34:35]

dkrahn@ , friendly ping

[Alexander Alekseev, 2016-03-09 01:40:16]

https://codereview.chromium.org/1738023002/diff/100001/chromeos/login/auth/cr...
File chromeos/login/auth/cryptohome_authenticator.cc (right):

https://codereview.chromium.org/1738023002/diff/100001/chromeos/login/auth/cr...
chromeos/login/auth/cryptohome_authenticator.cc:258:
CryptohomeMigrationToGaiaId::ALREADY_MIGRATED);
On 2016/03/07 17:56:34, stevenjb wrote:
> nit: {}

Done.

[Darren Krahn, 2016-03-09 18:12:43]

dkrahn@chromium.org changed reviewers:
+ dkrahn@chromium.org

[Darren Krahn, 2016-03-09 18:12:44]

lgtm for chromeos/cryptohome and chromeos/dbus

Should there be unit tests for the logic in chromeos/login?

[Alexander Alekseev, 2016-03-09 20:53:43]

Description was changed from

==========
ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual
==========

to

==========
ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual
==========

[Alexander Alekseev, 2016-03-09 20:53:43]

alemate@chromium.org changed reviewers:
- dkrahn@google.com

[Alexander Alekseev, 2016-03-09 20:54:08]

On 2016/03/09 18:12:44, Darren Krahn wrote:
> lgtm for chromeos/cryptohome and chromeos/dbus
> 
> Should there be unit tests for the logic in chromeos/login?

Added crbug.com/593451 .
Done.

[Alexander Alekseev, 2016-03-09 20:54:14]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 20:54:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738023002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738023002/120001

[commit-bot: I haz the power, 2016-03-09 22:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 22:23:25]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-03-09 22:54:23]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-03-09 22:54:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1738023002/#ps120001
(title: "Update after review.")

[commit-bot: I haz the power, 2016-03-09 22:54:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1738023002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1738023002/120001

[commit-bot: I haz the power, 2016-03-09 23:02:43]

Description was changed from

==========
ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual
==========

to

==========
ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual
==========

[commit-bot: I haz the power, 2016-03-09 23:02:44]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-09 23:03:51]

Description was changed from

==========
ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual
==========

to

==========
ChromeOS: Add RenameCryptohome and migration code.

This CL adds support for renaming existing cryptohomes to new id
(RenameCreptohome dbus call).

BUG=462823
TEST=manual

Committed: https://crrev.com/ad238d39cab83b2c09094a2f769e603bedb40e54
Cr-Commit-Position: refs/heads/master@{#380253}
==========

[commit-bot: I haz the power, 2016-03-09 23:03:53]

Patchset 7 (id:??) landed as
https://crrev.com/ad238d39cab83b2c09094a2f769e603bedb40e54
Cr-Commit-Position: refs/heads/master@{#380253}