Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1737953003: Have mock speech recognizer reset and release its recognizer upon ending. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have mock speech recognizer reset and release its recognizer upon ending. Take care of leaks attributed to this mock object - it unnecessarily retaining a WebSpeechRecognitionHandle beyond completion of the final 'ended' notification to it. R=dmazzoni BUG=506529 Committed: https://crrev.com/4cae4994fdd7fc1db4e88de568d57d7f1367f962 Cr-Commit-Position: refs/heads/master@{#378252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M components/test_runner/mock_web_speech_recognizer.cc View 4 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-26 11:46:25 UTC) #2
dmazzoni
lgtm
4 years, 9 months ago (2016-02-29 18:30:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737953003/1
4 years, 9 months ago (2016-02-29 18:46:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/110467)
4 years, 9 months ago (2016-02-29 18:55:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737953003/1
4 years, 9 months ago (2016-02-29 19:42:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 20:10:06 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 20:11:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cae4994fdd7fc1db4e88de568d57d7f1367f962
Cr-Commit-Position: refs/heads/master@{#378252}

Powered by Google App Engine
This is Rietveld 408576698