Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1737933003: Add primaryFont ASSERT to LayoutTextControl::getAvgCharWidth (Closed)

Created:
4 years, 10 months ago by eae
Modified:
4 years, 10 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add primaryFont ASSERT to LayoutTextControl::getAvgCharWidth BUG=535031 R=szager@chromium.org Committed: https://crrev.com/5e70ee0ac3bcb860eca4113139fdf4cfa77ce9f4 Cr-Commit-Position: refs/heads/master@{#378063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
4 years, 10 months ago (2016-02-26 19:31:01 UTC) #1
szager1
lgtm
4 years, 10 months ago (2016-02-27 00:14:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737933003/1
4 years, 10 months ago (2016-02-27 00:27:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-27 01:46:24 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 01:47:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5e70ee0ac3bcb860eca4113139fdf4cfa77ce9f4
Cr-Commit-Position: refs/heads/master@{#378063}

Powered by Google App Engine
This is Rietveld 408576698