Chromium Code Reviews| Index: components/profile_service/profile_app.h |
| diff --git a/components/profile_service/profile_app.h b/components/profile_service/profile_app.h |
| index 80c0130d5d4a4a6ea7048ff149dc8a7b2948fde4..e7b8bce8cbd9bd247a3d59218204b6e151148cfe 100644 |
| --- a/components/profile_service/profile_app.h |
| +++ b/components/profile_service/profile_app.h |
| @@ -6,7 +6,6 @@ |
| #define COMPONENTS_PROFILE_SERVICE_PROFILE_APP_H_ |
| #include "components/filesystem/lock_table.h" |
| -#include "components/leveldb/public/interfaces/leveldb.mojom.h" |
| #include "components/profile_service/public/interfaces/profile.mojom.h" |
| #include "mojo/public/cpp/bindings/binding_set.h" |
| #include "mojo/services/tracing/public/cpp/tracing_impl.h" |
| @@ -23,16 +22,12 @@ scoped_ptr<mojo::ShellClient> CreateProfileApp(); |
| // Application which hands off per-profile services. |
| // |
| -// This Application serves ProfileService, and serves LevelDBService since most |
| -// of the users of leveldb will want to write directly to the Directory |
| -// provided by the ProfileService; we want file handling to be done in the same |
| -// process to minimize IPC. |
| -// |
| -// In the future, this application will probably also offer any service that |
| -// most Profile using applications will need, such as preferences. |
| +// This Application serves ProfileService. In the future, this application will |
| +// probably also offer any service that most Profile using applications will |
| +// need, such as preferences, but these will need to be served off of separate |
| +// threads; this class will have to be made into something like core services. |
|
jam
2016/03/03 16:32:10
nit: the "core services" comment is gonna be indec
|
| class ProfileApp : public mojo::ShellClient, |
| - public mojo::InterfaceFactory<ProfileService>, |
| - public mojo::InterfaceFactory<leveldb::LevelDBService> { |
| + public mojo::InterfaceFactory<ProfileService> { |
| public: |
| ProfileApp(); |
| ~ProfileApp() override; |
| @@ -65,18 +60,11 @@ class ProfileApp : public mojo::ShellClient, |
| void Create(mojo::Connection* connection, |
| mojo::InterfaceRequest<ProfileService> request) override; |
| - // |InterfaceFactory<LevelDBService>| implementation: |
| - void Create(mojo::Connection* connection, |
| - mojo::InterfaceRequest<leveldb::LevelDBService> request) override; |
| - |
| mojo::TracingImpl tracing_; |
| scoped_ptr<ProfileService> profile_service_; |
| mojo::BindingSet<ProfileService> profile_bindings_; |
| - scoped_ptr<leveldb::LevelDBService> leveldb_service_; |
| - mojo::BindingSet<leveldb::LevelDBService> leveldb_bindings_; |
| - |
| scoped_ptr<filesystem::LockTable> lock_table_; |
| base::FilePath profile_data_dir_; |