mojo leveldb: Get profile and leveldb connected to DOMStorageContext.

content/browser/storage_partition_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_STORAGE_PARTITION_IMPL_H_
 #define CONTENT_BROWSER_STORAGE_PARTITION_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/compiler_specific.h"
@@ skipping 114 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionImplTest, RemoveCookieForever);
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionImplTest, RemoveCookieLastHour);
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionImplTest,
                            RemoveUnprotectedLocalStorageForever);
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionImplTest,
                            RemoveProtectedLocalStorageForever);
   FRIEND_TEST_ALL_PREFIXES(StoragePartitionImplTest,
                            RemoveLocalStorageForLastWeek);
 
   // The |partition_path| is the absolute path to the root of this
-  // StoragePartition's on-disk storage.
+  // StoragePartition's on-disk storage. |local_partition_path| is the relative
+  // path to said root minus the local profile directory for cases where we
+  // can't access anything outside of the local profile.
   //
   // If |in_memory| is true, the |partition_path| is (ab)used as a way of
   // distinguishing different in-memory partitions, but nothing is persisted
   // on to disk.
-  static StoragePartitionImpl* Create(BrowserContext* context,
-                                      bool in_memory,
-                                      const base::FilePath& profile_path);
+  static StoragePartitionImpl* Create(
+      BrowserContext* context,
+      bool in_memory,
+      const base::FilePath& profile_path,
+      const base::FilePath& local_partition_path);

[michaeln, 2016/03/16 03:11:13]

These two paths are confusing and i think potentially error prone. As coded...

  profile_path = {somerootdir}/rel_path
  local_partition_path = rel_path

That looks error prone because theirs nothing keeping a caller from passing in
values such that profile_path does not end in rel_path, and its difficult to
explain what the caller should pass in. Wdyt about something like...

  profile_path = {somerootdir}
  partition_relative_path = rel_path
 
Where the directory the partition should use is formed as:
{somerootdir}/rel_path.

[Elliot Glaysher, 2016/03/17 19:29:44]

Done.

 
   CONTENT_EXPORT StoragePartitionImpl(
       BrowserContext* browser_context,
       const base::FilePath& partition_path,
       storage::QuotaManager* quota_manager,
       ChromeAppCacheService* appcache_service,
       storage::FileSystemContext* filesystem_context,
       storage::DatabaseTracker* database_tracker,
       DOMStorageContextWrapper* dom_storage_context,
       IndexedDBContextImpl* indexed_db_context,
@@ skipping 58 matching lines @@
   // StoragePartitionImplMap which then owns StoragePartitionImpl. When the
   // BrowserContext is destroyed, |this| will be destroyed too.
   BrowserContext* browser_context_;
 
   DISALLOW_COPY_AND_ASSIGN(StoragePartitionImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_STORAGE_PARTITION_IMPL_H_