Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 173793002: Check and clear date cache in DateCurrentTime, DateLocalTimezone and getTimezoneOffset. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev, tfarina
Visibility:
Public.

Description

Check and clear date cache in DateCurrentTime, DateLocalTimezone and getTimezoneOffset. BUG=142141 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19711

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : fix caching of offset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M src/date.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/date.js View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
6 years, 10 months ago (2014-02-20 14:04:59 UTC) #1
tfarina
https://codereview.chromium.org/173793002/diff/40001/src/date.h File src/date.h (right): https://codereview.chromium.org/173793002/diff/40001/src/date.h#newcode125 src/date.h:125: void CheckTimezone() { looks like you follow surround code ...
6 years, 10 months ago (2014-02-20 17:58:46 UTC) #2
rossberg
lgtm
6 years, 10 months ago (2014-02-25 12:00:03 UTC) #3
ulan
6 years, 9 months ago (2014-03-07 10:01:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r19711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698