Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1737913002: Parameterize CallbackStack over initial block size. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parameterize CallbackStack over initial block size. CallbackStack keeps a chain of blocks, extending it as needed. So as to allow stacks with varying block sizes, have its constructor take the block size to use as argument. R=haraken BUG=420515 Committed: https://crrev.com/c0cce2c0c7beaa0793942997754b62d9f1f6cdb1 Cr-Commit-Position: refs/heads/master@{#377865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 4 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.cpp View 6 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-25 22:24:43 UTC) #2
haraken
LGTM (If we want to reduce the size in M50, I think we need to ...
4 years, 10 months ago (2016-02-26 08:47:18 UTC) #3
sof
On 2016/02/26 08:47:18, haraken wrote: > LGTM > > (If we want to reduce the ...
4 years, 10 months ago (2016-02-26 08:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737913002/1
4 years, 10 months ago (2016-02-26 09:59:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 10:52:49 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 10:53:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0cce2c0c7beaa0793942997754b62d9f1f6cdb1
Cr-Commit-Position: refs/heads/master@{#377865}

Powered by Google App Engine
This is Rietveld 408576698