Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 17379024: GTTF: Extract a function to launch child gtest process. (Closed)

Created:
7 years, 6 months ago by Paweł Hajdan Jr.
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

GTTF: Extract a function to launch child gtest process. This will make it possible to make unit test launcher launch child gtest processes. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208264

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : bugfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -70 lines) Patch
M base/test/test_launcher.h View 2 chunks +6 lines, -0 lines 0 comments Download
M base/test/test_launcher.cc View 2 chunks +59 lines, -0 lines 0 comments Download
M content/public/test/test_launcher.cc View 1 2 5 chunks +20 lines, -70 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 6 months ago (2013-06-21 22:57:08 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-24 16:02:09 UTC) #2
Paweł Hajdan Jr.
7 years, 6 months ago (2013-06-24 21:43:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r208264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698