Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 17379021: [telemetry] Update record_wpr to look for measurements everywhere. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/docs/telemetry.page.record_wpr.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index ac85effb6db560e9ac1572803192714fd1dd23c0..161a79f34266331b9203f88c3f0e673bc508416b 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -59,10 +59,9 @@ class RecordPage(page_test.PageTest):
return actions
-def Main(measurement_dir):
- measurements = discover.DiscoverClasses(measurement_dir,
- os.path.join(measurement_dir, '..'),
- page_measurement.PageMeasurement)
+def Main(base_dir):
+ measurements = discover.DiscoverClasses(base_dir, base_dir,
+ page_measurement.PageMeasurement)
options = browser_options.BrowserOptions()
parser = options.CreateParser('%prog <page_set>')
page_runner.AddCommandLineOptions(parser)
@@ -98,7 +97,7 @@ def Main(measurement_dir):
if results.skipped:
logging.warning('Some pages were skipped. The recording has not been '
'updated for these pages.')
- logging.warning('Skipped pages:\n%s', '\n'.join(results.skipped))
+ logging.warning('Skipped pages:\n%s', '\n'.join(zip(*results.skipped)[0]))
if results.successes:
# Update the metadata for the pages which were recorded.
« no previous file with comments | « tools/telemetry/docs/telemetry.page.record_wpr.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698