Issue 17379016: Introduce ChildNode IDL interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17379016: Introduce ChildNode IDL interface (Closed)

Created:
7 years, 6 months ago by do-not-use

Modified:
7 years, 6 months ago

Reviewers:
haraken, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Introduce ChildNode IDL interface Introduce ChildNode IDL interface and use 'implements' statements for DocumentType, Element and CharacterData to avoid duplication and match the specification: http://dom.spec.whatwg.org/#childnode Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152708

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -23 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/CharacterData.idl	View		1 chunk	+0 lines, -5 lines	0 comments	Download
A +	Source/core/dom/ChildNode.idl	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
M	Source/core/dom/DocumentType.idl	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/dom/Element.idl	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/17379016/diff/1/Source/core/dom/ChildNode.idl File Source/core/dom/ChildNode.idl (right): https://codereview.chromium.org/17379016/diff/1/Source/core/dom/ChildNode.idl#newcode4 Source/core/dom/ChildNode.idl:4: * Copyright (C) 2013 Samsumg Electronics. All rights ...

7 years, 6 months ago (2013-06-19 06:47:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17379016/5001

7 years, 6 months ago (2013-06-19 06:51:33 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages