Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 1737893003: [turbofan] Fix length in LowerJSCreateLiteralObject. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix length in LowerJSCreateLiteralObject. This fixes the length computation in for object literals in generic lowering. In rare cases (e.g. boilerplate at end of page) this could lead to out of bounds reads. R=bmeurer@chromium.org Committed: https://crrev.com/db8f0504b819eed060a7c6fa26e71032f892dc47 Cr-Commit-Position: refs/heads/master@{#34328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-26 12:02:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737893003/1
4 years, 10 months ago (2016-02-26 13:14:00 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 10 months ago (2016-02-26 13:14:02 UTC) #5
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-26 13:14:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737893003/1
4 years, 10 months ago (2016-02-26 13:22:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 13:23:46 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 13:25:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8f0504b819eed060a7c6fa26e71032f892dc47
Cr-Commit-Position: refs/heads/master@{#34328}

Powered by Google App Engine
This is Rietveld 408576698