Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1737873002: Fix cc_blink_unittests link errors in static GN builds after r377586. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 9 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cc_blink_unittests link errors in static GN builds after r377586. BUG=561879 TBR=yukishiino@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/cb956fa215ae6003ff76f62b94404c765171e5c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
jam
4 years, 10 months ago (2016-02-25 21:05:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737873002/1
4 years, 10 months ago (2016-02-25 21:08:44 UTC) #4
jam
sigh, i give up waiting on swarming. i'll dcommit
4 years, 10 months ago (2016-02-25 22:28:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb956fa215ae6003ff76f62b94404c765171e5c5 Cr-Commit-Position: refs/heads/master@{#377688}
4 years, 10 months ago (2016-02-25 22:31:21 UTC) #8
jam
Committed patchset #1 (id:1) manually as cb956fa215ae6003ff76f62b94404c765171e5c5 (presubmit successful).
4 years, 10 months ago (2016-02-25 22:32:02 UTC) #10
Yuki
LGTM! Thanks for fixing this breakage very soon.
4 years, 10 months ago (2016-02-26 06:20:33 UTC) #11
haraken
LGTM
4 years, 10 months ago (2016-02-26 08:35:24 UTC) #12
brettw
I'm confused about this change. The cc/blink target isn't a test target. Why link to ...
4 years, 9 months ago (2016-03-21 23:47:18 UTC) #13
Yuki
4 years, 9 months ago (2016-03-22 10:46:50 UTC) #14
Message was sent while issue was closed.
On 2016/03/21 23:47:18, brettw wrote:
> I'm confused about this change. The cc/blink target isn't a test target. Why
> link to blink_for_unittests?

That's right.  I'm preparing the fix at http://crrev.com/1820903005 .  Once I
confirm the bots are happy with the CL, I'll send it to review.

Powered by Google App Engine
This is Rietveld 408576698