Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1737853002: PPC: [runtime] Unify comparison operator runtime entries. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Unify comparison operator runtime entries. Port 55b4df7357557eb16377ad9227e4e0a4224b7885 Original commit message: Only use one set of %StrictEquals/%StrictNotEquals and %Equals/%NotEquals runtime entries for both the interpreter and the old-style CompareICStub. The long-term plan is to update the CompareICStub to also return boolean values, and even allow some more code sharing with the interpreter there. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/4da2e3dbcfc686f68e56c0ad5575257dc2d8ccf1 Cr-Commit-Position: refs/heads/master@{#34306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-25 20:36:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737853002/1
4 years, 10 months ago (2016-02-25 20:36:44 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 20:52:18 UTC) #5
JoranSiu
On 2016/02/25 20:52:18, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-25 21:47:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737853002/1
4 years, 10 months ago (2016-02-25 21:49:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 21:51:34 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 21:52:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4da2e3dbcfc686f68e56c0ad5575257dc2d8ccf1
Cr-Commit-Position: refs/heads/master@{#34306}

Powered by Google App Engine
This is Rietveld 408576698