Use regular chromium recipes for Chromium Mojo.

Use regular chromium recipes for Chromium Mojo.

Use the regular chromium recipe instead of custom chromium_mojo.py
Drop slavebuilddir customization; add builders.py entry.
Add chromium_mojo.py builders list with bot configs.
FYI waterfall: https://build.chromium.org/p/chromium.mojo/console

Uses new client-side testing/buildbot/chromium.mojo.json config.
( added by https://codereview.chromium.org/1740013002 )

Train to generate new expectations, remove old.
( depends on force=True: https://codereview.chromium.org/1744653002 )

BUG=589923
TEST=waterfall works as before (w/master restart?).
R=dpranke@chromium.org,phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299114

[msw, 2016-02-26 00:07:28]

Description was changed from

==========
Use regular chromium recipes for Chromium Mojo.

BUG=589923
==========

to

==========
Use regular chromium recipes for Chromium Mojo.

Depends on https://codereview.chromium.org/1740013002/

BUG=589923
==========

[Dirk Pranke, 2016-02-26 00:15:54]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org

[Dirk Pranke, 2016-02-26 00:15:55]

comments below. Paweł should review this to double-check me and so that he's
aware of the changes ...

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py (right):

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:18: # TODO(msw):
Leave default? 'TARGET_BITS': 32,
uncomment.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:24: #
'android_config': 'main_builder_mb',
not sure about this one; uncomment or ask stip@, martiniss@, or jbudorick@.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:31: # ],
you need this block.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:43: # ],
don't need this.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:45: # 'bot_type':
'builder',
this should be 'builder_tester', and you need it.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:49: # },
uncomment; needed.

[msw, 2016-02-26 01:33:19]

Description was changed from

==========
Use regular chromium recipes for Chromium Mojo.

Depends on https://codereview.chromium.org/1740013002/

BUG=589923
==========

to

==========
Use regular chromium recipes for Chromium Mojo.

Depends on https://codereview.chromium.org/1740013002/

Currently fails scripts/slave/unittests/recipe_simulation_test.py train:
chromium.full_chromium_mojo_Chromium_Mojo_Linux failed: Traceback (most recent
call last):
[... SNIPPED FOR BREVITY ...]
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 204, in prepare_checkout
    bot_config, root_solution_revision, force=force)
  File
"/work/infra/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py",
line 220, in _inner
    return func(*a, **kw)
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 168, in ensure_checkout
    assert update_step.json.output['did_run']
AssertionError

BUG=589923
==========

[msw, 2016-02-26 01:38:00]

msw@chromium.org changed reviewers:
+ hinoka@chromium.org

[msw, 2016-02-26 01:38:01]

Hey Ryan, this CL is failing training because the prepare_checkout /
ensure_checkout / update_step is not running:

chromium.full_chromium_mojo_Chromium_Mojo_Linux failed: Traceback (most recent
call last):
[... SNIPPED FOR BREVITY ...]
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 204, in prepare_checkout
    bot_config, root_solution_revision, force=force)
  File
"/work/infra/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py",
line 220, in _inner
    return func(*a, **kw)
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 168, in ensure_checkout
    assert update_step.json.output['did_run']
AssertionError

Should I add this master to the list that forces update (is it
build/scripts/slave/bot_update.py?) or should I wait for your CL that fixes that
issue more widely (is it https://codereview.chromium.org/1694383003/ that always
forces update?). Thanks!

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py (right):

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:18: # TODO(msw):
Leave default? 'TARGET_BITS': 32,
On 2016/02/26 00:15:54, Dirk Pranke wrote:
> uncomment.

Done.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:24: #
'android_config': 'main_builder_mb',
On 2016/02/26 00:15:54, Dirk Pranke wrote:
> not sure about this one; uncomment or ask stip@, martiniss@, or jbudorick@.

Done.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:31: # ],
On 2016/02/26 00:15:54, Dirk Pranke wrote:
> you need this block.

Done.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:43: # ],
On 2016/02/26 00:15:54, Dirk Pranke wrote:
> don't need this.

Done.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:45: # 'bot_type':
'builder',
On 2016/02/26 00:15:54, Dirk Pranke wrote:
> this should be 'builder_tester', and you need it.

Done.

https://codereview.chromium.org/1737843003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_mojo.py:49: # },
On 2016/02/26 00:15:54, Dirk Pranke wrote:
> uncomment; needed.

Done.

[msw, 2016-02-29 20:52:35]

Description was changed from

==========
Use regular chromium recipes for Chromium Mojo.

Depends on https://codereview.chromium.org/1740013002/

Currently fails scripts/slave/unittests/recipe_simulation_test.py train:
chromium.full_chromium_mojo_Chromium_Mojo_Linux failed: Traceback (most recent
call last):
[... SNIPPED FOR BREVITY ...]
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 204, in prepare_checkout
    bot_config, root_solution_revision, force=force)
  File
"/work/infra/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py",
line 220, in _inner
    return func(*a, **kw)
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 168, in ensure_checkout
    assert update_step.json.output['did_run']
AssertionError

BUG=589923
==========

to

==========
Use regular chromium recipes for Chromium Mojo.

Depends on https://codereview.chromium.org/1740013002/

Currently fails scripts/slave/unittests/recipe_simulation_test.py train:
( depends on https://codereview.chromium.org/1744653002/ )
chromium.full_chromium_mojo_Chromium_Mojo_Linux failed: Traceback (most recent
call last):
[... SNIPPED FOR BREVITY ...]
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 204, in prepare_checkout
    bot_config, root_solution_revision, force=force)
  File
"/work/infra/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py",
line 220, in _inner
    return func(*a, **kw)
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 168, in ensure_checkout
    assert update_step.json.output['did_run']
AssertionError

BUG=589923
==========

[msw, 2016-03-03 22:28:54]

Description was changed from

==========
Use regular chromium recipes for Chromium Mojo.

Depends on https://codereview.chromium.org/1740013002/

Currently fails scripts/slave/unittests/recipe_simulation_test.py train:
( depends on https://codereview.chromium.org/1744653002/ )
chromium.full_chromium_mojo_Chromium_Mojo_Linux failed: Traceback (most recent
call last):
[... SNIPPED FOR BREVITY ...]
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 204, in prepare_checkout
    bot_config, root_solution_revision, force=force)
  File
"/work/infra/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py",
line 220, in _inner
    return func(*a, **kw)
  File "/work/infra/build/scripts/slave/recipe_modules/chromium_tests/api.py",
line 168, in ensure_checkout
    assert update_step.json.output['did_run']
AssertionError

BUG=589923
==========

to

==========
Use regular chromium recipes for Chromium Mojo.

Use the regular chromium recipe instead of custom chromium_mojo.py
FYI waterfall: https://build.chromium.org/p/chromium.mojo/console

Uses new client-side testing/buildbot/chromium.mojo.json config.
( added by https://codereview.chromium.org/1740013002 )

Train to generate new expectations, remove old.
( depends on force=True: https://codereview.chromium.org/1744653002 )

BUG=589923
TEST=Chromium Mojo FYI Waterfall (after master restart?) still builds, runs
mojo_apptests and views_mus_unittests successfully (app tests fail on Android
right now).
R=dpranke@chromium.org,phajdan.jr@chromium.org
==========

[msw, 2016-03-03 22:28:54]

msw@chromium.org changed reviewers:
- hinoka@chromium.org

[msw, 2016-03-03 22:34:48]

Description was changed from

==========
Use regular chromium recipes for Chromium Mojo.

Use the regular chromium recipe instead of custom chromium_mojo.py
FYI waterfall: https://build.chromium.org/p/chromium.mojo/console

Uses new client-side testing/buildbot/chromium.mojo.json config.
( added by https://codereview.chromium.org/1740013002 )

Train to generate new expectations, remove old.
( depends on force=True: https://codereview.chromium.org/1744653002 )

BUG=589923
TEST=Chromium Mojo FYI Waterfall (after master restart?) still builds, runs
mojo_apptests and views_mus_unittests successfully (app tests fail on Android
right now).
R=dpranke@chromium.org,phajdan.jr@chromium.org
==========

to

==========
Use regular chromium recipes for Chromium Mojo.

Use the regular chromium recipe instead of custom chromium_mojo.py
Drop slavebuilddir customization; add builders.py entry.
Add chromium_mojo.py builders list with bot configs.
FYI waterfall: https://build.chromium.org/p/chromium.mojo/console

Uses new client-side testing/buildbot/chromium.mojo.json config.
( added by https://codereview.chromium.org/1740013002 )

Train to generate new expectations, remove old.
( depends on force=True: https://codereview.chromium.org/1744653002 )

BUG=589923
TEST=waterfall works as before (w/master restart?).
R=dpranke@chromium.org,phajdan.jr@chromium.org
==========

[msw, 2016-03-03 22:35:15]

Hey Dirk and Paweł, please take a look; thanks!

[Paweł Hajdan Jr., 2016-03-04 07:59:15]

LGTM

[msw, 2016-03-04 17:49:22]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-03-04 17:49:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1737843003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1737843003/60001

[commit-bot: I haz the power, 2016-03-04 17:53:11]

Description was changed from

==========
Use regular chromium recipes for Chromium Mojo.

Use the regular chromium recipe instead of custom chromium_mojo.py
Drop slavebuilddir customization; add builders.py entry.
Add chromium_mojo.py builders list with bot configs.
FYI waterfall: https://build.chromium.org/p/chromium.mojo/console

Uses new client-side testing/buildbot/chromium.mojo.json config.
( added by https://codereview.chromium.org/1740013002 )

Train to generate new expectations, remove old.
( depends on force=True: https://codereview.chromium.org/1744653002 )

BUG=589923
TEST=waterfall works as before (w/master restart?).
R=dpranke@chromium.org,phajdan.jr@chromium.org
==========

to

==========
Use regular chromium recipes for Chromium Mojo.

Use the regular chromium recipe instead of custom chromium_mojo.py
Drop slavebuilddir customization; add builders.py entry.
Add chromium_mojo.py builders list with bot configs.
FYI waterfall: https://build.chromium.org/p/chromium.mojo/console

Uses new client-side testing/buildbot/chromium.mojo.json config.
( added by https://codereview.chromium.org/1740013002 )

Train to generate new expectations, remove old.
( depends on force=True: https://codereview.chromium.org/1744653002 )

BUG=589923
TEST=waterfall works as before (w/master restart?).
R=dpranke@chromium.org,phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299114
==========

[commit-bot: I haz the power, 2016-03-04 17:53:11]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299114

[Dirk Pranke, 2016-03-04 20:38:17]

lgtm