[WIN]Save work area of window and adjust bounds to ensure it fit on screen before show.

chrome/browser/ui/views/extensions/native_app_window_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/native_app_window_views.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
 #include "chrome/browser/ui/views/extensions/shell_window_frame_view.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "extensions/common/draggable_region.h"
+#include "ui/gfx/screen.h"
 #include "ui/views/controls/webview/webview.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/window/non_client_view.h"
 
 #if defined(OS_WIN)
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/web_applications/web_app_ui.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "ui/base/win/shell.h"
 #include "ui/views/win/hwnd_util.h"
@@ skipping 131 matching lines @@
   if (position_specified && !window_bounds.IsEmpty())
     init_params.bounds = window_bounds;
   window_->Init(init_params);
 
   gfx::Rect adjusted_bounds = window_bounds;
   adjusted_bounds.Inset(-GetFrameInsets());
   // Center window if no position was specified.
   if (!position_specified)
     window_->CenterWindow(adjusted_bounds.size());
   else if (!adjusted_bounds.IsEmpty() && adjusted_bounds != window_bounds)
     window_->SetBounds(adjusted_bounds);

[oshima, 2013/06/20 19:46:32]

The reason why it's currently broken on chromeos is that
this code sets bounds AFTER Widget::Init. ChromeOS already have
a logic to fit to the screen when created. I also think chrome must
have the same logic as we don't want to restore chrome offscreen.
Can't we just set the bounds in init_params, and leave it to underlying logic?

[zhchbin, 2013/06/21 06:36:31]

My patch didn't change these lines. I think the right code position that broke
chromeos is native_app_window_->SetBounds(new_bounds); in the shell_window.cc
line 210(My patch). However, now I'm just working on windows for the problem,
and I can't reproduce this problem on Linux(GTK+) and MAC platform(With the
steps on the issue 225734). I will update this patch to windows only. Do you and
@scheib agree? Hope this code review wouldn't waste your time.

[oshima, 2013/06/21 16:13:30]

Sorry I lied. I mixed up with something else, so please ignore my comments
above.
I'll check existing code again and will comment a bit later.
This doesn't work on cros as well. Does new patch fixes this on cros as well?

 
   // Register accelarators supported by app windows.
   // TODO(jeremya/stevenjb): should these be registered for panels too?
   views::FocusManager* focus_manager = GetFocusManager();
   const std::map<ui::Accelerator, int>& accelerator_table =
       GetAcceleratorTable();
   for (std::map<ui::Accelerator, int>::const_iterator iter =
            accelerator_table.begin();
        iter != accelerator_table.end(); ++iter) {
     focus_manager->RegisterAccelerator(
@@ skipping 212 matching lines @@
   // the specified amount of space to fit the window controls in, and return a
   // number larger than the real frame insets. Most window controls are smaller
   // than 1000x1000px, so this should be big enough.
   gfx::Rect client_bounds = gfx::Rect(1000, 1000);
   gfx::Rect window_bounds =
       window_->non_client_view()->GetWindowBoundsForClientBounds(
           client_bounds);
   return window_bounds.InsetsFrom(client_bounds);
 }
 
+gfx::Rect NativeAppWindowViews::GetScreenBounds() const {
+  return gfx::Screen::GetScreenFor(window_->GetNativeView())->
+      GetDisplayMatching(GetBounds()).work_area();
+}
+
 gfx::NativeView NativeAppWindowViews::GetHostView() const {
   return window_->GetNativeView();
 }
 
 gfx::Point NativeAppWindowViews::GetDialogPosition(const gfx::Size& size) {
   gfx::Size shell_window_size = window_->GetWindowBoundsInScreen().size();
   return gfx::Point(shell_window_size.width() / 2 - size.width() / 2,
                     shell_window_size.height() / 2 - size.height() / 2);
 }
 
@@ skipping 326 matching lines @@
 }
 
 //------------------------------------------------------------------------------
 // NativeAppWindow::Create
 
 // static
 NativeAppWindow* NativeAppWindow::Create(
     ShellWindow* shell_window, const ShellWindow::CreateParams& params) {
   return new NativeAppWindowViews(shell_window, params);
 }