src/regexp-macro-assembler-irregexp.h - Issue 17378: Capture register clearing on loop iteration

Side by Side Diff: src/regexp-macro-assembler-irregexp.h

Issue 17378: Capture register clearing on loop iteration (Closed)

Patch Set: Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« src/regexp-macro-assembler-ia32.cc ('K') | « src/regexp-macro-assembler-ia32.cc ('k') | src/regexp-macro-assembler-irregexp.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2008 the V8 project authors. All rights reserved.	1 // Copyright 2008 the V8 project authors. All rights reserved.

2 // Redistribution and use in source and binary forms, with or without	2 // Redistribution and use in source and binary forms, with or without

3 // modification, are permitted provided that the following conditions are	3 // modification, are permitted provided that the following conditions are

4 // met:	4 // met:

5 //	5 //

6 // * Redistributions of source code must retain the above copyright	6 // * Redistributions of source code must retain the above copyright

7 // notice, this list of conditions and the following disclaimer.	7 // notice, this list of conditions and the following disclaimer.

8 // * Redistributions in binary form must reproduce the above	8 // * Redistributions in binary form must reproduce the above

9 // copyright notice, this list of conditions and the following	9 // copyright notice, this list of conditions and the following

10 // disclaimer in the documentation and/or other materials provided	10 // disclaimer in the documentation and/or other materials provided

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 virtual void GoTo(Label* label);	59 virtual void GoTo(Label* label);

60 virtual void PushBacktrack(Label* label);	60 virtual void PushBacktrack(Label* label);

61 virtual void Succeed();	61 virtual void Succeed();

62 virtual void Fail();	62 virtual void Fail();

63 virtual void PopRegister(int register_index);	63 virtual void PopRegister(int register_index);

64 virtual void PushRegister(int register_index,	64 virtual void PushRegister(int register_index,

65 StackCheckFlag check_stack_limit);	65 StackCheckFlag check_stack_limit);

66 virtual void AdvanceRegister(int reg, int by); // r[reg] += by.	66 virtual void AdvanceRegister(int reg, int by); // r[reg] += by.

67 virtual void SetRegister(int register_index, int to);	67 virtual void SetRegister(int register_index, int to);

68 virtual void WriteCurrentPositionToRegister(int reg, int cp_offset);	68 virtual void WriteCurrentPositionToRegister(int reg, int cp_offset);

	69 virtual void ClearRegister(int reg);
	Lasse Reichstein 2009/01/14 08:38:34 Could perhaps be called "ClearPositionRegister", b Could perhaps be called "ClearPositionRegister", because the value it resets to is the -1 position. It does not make sense for, e.g., registers used as counters. Christian Plesner Hansen 2009/01/14 11:31:35 Good point. Good point.
69 virtual void ReadCurrentPositionFromRegister(int reg);	70 virtual void ReadCurrentPositionFromRegister(int reg);

70 virtual void WriteStackPointerToRegister(int reg);	71 virtual void WriteStackPointerToRegister(int reg);

71 virtual void ReadStackPointerFromRegister(int reg);	72 virtual void ReadStackPointerFromRegister(int reg);

72 virtual void LoadCurrentCharacter(int cp_offset,	73 virtual void LoadCurrentCharacter(int cp_offset,

73 Label* on_end_of_input,	74 Label* on_end_of_input,

74 bool check_bounds = true,	75 bool check_bounds = true,

75 int characters = 1);	76 int characters = 1);

76 virtual void CheckCharacter(uint32_t c, Label* on_equal);	77 virtual void CheckCharacter(uint32_t c, Label* on_equal);

77 virtual void CheckCharacterAfterAnd(uint32_t c,	78 virtual void CheckCharacterAfterAnd(uint32_t c,

78 uint32_t mask,	79 uint32_t mask,

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
130 // True if the assembler owns the buffer, false if buffer is external.	131 // True if the assembler owns the buffer, false if buffer is external.

131 bool own_buffer_;	132 bool own_buffer_;

132 Label backtrack_;	133 Label backtrack_;

133	134

134 DISALLOW_IMPLICIT_CONSTRUCTORS(RegExpMacroAssemblerIrregexp);	135 DISALLOW_IMPLICIT_CONSTRUCTORS(RegExpMacroAssemblerIrregexp);

135 };	136 };

136	137

137 } } // namespace v8::internal	138 } } // namespace v8::internal

138	139

139 #endif // V8_REGEXP_MACRO_ASSEMBLER_IRREGEXP_H_	140 #endif // V8_REGEXP_MACRO_ASSEMBLER_IRREGEXP_H_

OLD	NEW