Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1737773002: Find SDK properly when analyzing files in package mode. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Find SDK properly when analyzing files in package mode. R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/8dc6261f1076c264472b6ea35117351b1de2b3b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analyzer_cli/lib/src/package_analyzer.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-25 18:04:46 UTC) #2
pquitslund
LGTM
4 years, 10 months ago (2016-02-25 18:18:32 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-25 18:32:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8dc6261f1076c264472b6ea35117351b1de2b3b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698