Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1737763002:
Reshuffle ios slave machines (Closed)
DescriptionReshuffle ios slave machines
One single build%d-a4 machine can't handle that many checkouts
(disk too small)
BUG=410088
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299017
Patch Set 1 #Patch Set 2 : Fixed typo #Patch Set 3 : Fixed yet another stupid mistake #Patch Set 4 : Hoping it'll be good this time. #
Total comments: 6
Patch Set 5 : Fixed pool names #Messages
Total messages: 32 (15 generated)
The CQ bit was checked by pgervais@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by pgervais@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by pgervais@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by pgervais@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
pgervais@chromium.org changed reviewers: + phajdan.jr@chromium.org, sergeyberezin@chromium.org, tandrii@chromium.org
Sergey: do a first check Andrii, Pawel: please review and tell me if this change is ok with you. Feel free to send to CQ and deploy if l-g-t-m'd
A few comments, otherwise looks fine (I didn't do a detailed review though). https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... File masters/master.tryserver.chromium.mac/slaves.cfg (right): https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... masters/master.tryserver.chromium.mac/slaves.cfg:105: # 9 + 1 builders for dbg Please check these numbers against the Capacity console, if you haven't done so yet (go/chrome-infra-graphs > Buildbot > Capacity). I *think* the load should be roughly even, given the CQ config, but it's worth looking at the actual load. CQ config: https://chromium.googlesource.com/chromium/src/+/master/infra/config/cq.cfg#67 https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... masters/master.tryserver.chromium.mac/slaves.cfg:126: 'pool': 'ios_cq', s/ios_cq/ios_cq_dbg/ https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... masters/master.tryserver.chromium.mac/slaves.cfg:137: 'pool': 'ios_cq', s/ios_cq/ios_cq_rel/
https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... File masters/master.tryserver.chromium.mac/slaves.cfg (right): https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... masters/master.tryserver.chromium.mac/slaves.cfg:105: # 9 + 1 builders for dbg On 2016/02/25 19:17:38, Sergey Berezin wrote: > Please check these numbers against the Capacity console, if you haven't done so > yet (go/chrome-infra-graphs > Buildbot > Capacity). I *think* the load should be > roughly even, given the CQ config, but it's worth looking at the actual load. > > CQ config: > https://chromium.googlesource.com/chromium/src/+/master/infra/config/cq.cfg#67 Without looking I think it's unnecessary because a lot of those machines are already permanently offline (9 to be precise), which means that we are already running all the builders on 2/3 of the machines. After looking, it appears that most of the load is caused by ios_dbg_simulator_ninja and ios_rel_device_ninja (max number of builds is around 10). Those builders are in different pools after this CL, and each pool has 22 and 23 builders respectively. So I think we're good. https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... masters/master.tryserver.chromium.mac/slaves.cfg:126: 'pool': 'ios_cq', On 2016/02/25 19:17:38, Sergey Berezin wrote: > s/ios_cq/ios_cq_dbg/ Done. https://codereview.chromium.org/1737763002/diff/60001/masters/master.tryserve... masters/master.tryserver.chromium.mac/slaves.cfg:137: 'pool': 'ios_cq', On 2016/02/25 19:17:38, Sergey Berezin wrote: > s/ios_cq/ios_cq_rel/ Done.
LGTM, thanks! (this time I actually reviewed it, though didn't carefully check the individual slaves allocation).
The CQ bit was checked by pgervais@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/80001
The CQ bit was unchecked by pgervais@chromium.org
The CQ bit was checked by pgervais@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737763002/80001
Message was sent while issue was closed.
Description was changed from ========== Reshuffle ios slave machines One single build%d-a4 machine can't handle that many checkouts (disk too small) BUG=410088 ========== to ========== Reshuffle ios slave machines One single build%d-a4 machine can't handle that many checkouts (disk too small) BUG=410088 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299017 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299017 |
