Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1737753002: Remove unnecessary class forward declaration for usb/bluetooth_chooser_bubble_delegate.h (Closed)

Created:
4 years, 10 months ago by juncai
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary class forward declaration for usb/bluetooth_chooser_bubble_delegate.h This patch removed unnecessary class forward declaration for usb_chooser_bubble_delegate.h and bluetooth_chooser_bubble_delegate.h BUG=492204 Committed: https://crrev.com/4b6f450f53651f903bfe9613d9159b59326ea0ff Cr-Commit-Position: refs/heads/master@{#377635}

Patch Set 1 : removed unnecessary class forward declaration for usb_chooser_bubble_delegate.h and bluetooth_chooser_bubble_delegate.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_bubble_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
juncai
reillyg@chromium.org: Please review changes in //chrome/browser/usb/usb_chooser_bubble_delegate.h msw@chromium.org: Please review changes in //chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.h
4 years, 10 months ago (2016-02-25 17:41:48 UTC) #2
msw
lgtm
4 years, 10 months ago (2016-02-25 17:49:59 UTC) #3
Reilly Grant (use Gerrit)
lgtm
4 years, 10 months ago (2016-02-25 18:02:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737753002/1
4 years, 10 months ago (2016-02-25 18:23:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 19:11:52 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 19:13:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b6f450f53651f903bfe9613d9159b59326ea0ff
Cr-Commit-Position: refs/heads/master@{#377635}

Powered by Google App Engine
This is Rietveld 408576698