third_party/WebKit/Source/devtools/front_end/devtools.js - Issue 1737733002: [DevTools] Handle emulated device scale factor and original device scale factor properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/devtools.js

Issue 1737733002: [DevTools] Handle emulated device scale factor and original device scale factor properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/DevToolsHost.idl ('K') | « third_party/WebKit/Source/core/inspector/DevToolsHost.idl ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/devtools.js

diff --git a/third_party/WebKit/Source/devtools/front_end/devtools.js b/third_party/WebKit/Source/devtools/front_end/devtools.js

index 9cb6bf2ea736795ec797f12d140f1dca0b6183a4..9da83256889a48f117346f0f0adecedb18bad1f6 100644

--- a/third_party/WebKit/Source/devtools/front_end/devtools.js

+++ b/third_party/WebKit/Source/devtools/front_end/devtools.js

@@ -400,13 +400,7 @@ InspectorFrontendHostImpl.prototype = {

setInspectedPageBounds: function(bounds)

{

- var converted = {

- x: Math.round(DevToolsHost.convertLengthForEmbedder(bounds.x)),

- y: Math.round(DevToolsHost.convertLengthForEmbedder(bounds.y)),

- width: Math.round(DevToolsHost.convertLengthForEmbedder(bounds.width)),

- height: Math.round(DevToolsHost.convertLengthForEmbedder(bounds.height))

- };

- DevToolsAPI.sendMessageToEmbedder("setInspectedPageBounds", [converted], null);

+ DevToolsAPI.sendMessageToEmbedder("setInspectedPageBounds", [bounds], null);

/**