Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: src/a64/lithium-a64.cc

Issue 173773002: A64: Remove a couple of already addressed TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1228 matching lines...) Expand 10 before | Expand all | Expand 10 after
1239 return new(zone()) LClassOfTestAndBranch(value, 1239 return new(zone()) LClassOfTestAndBranch(value,
1240 TempRegister(), 1240 TempRegister(),
1241 TempRegister()); 1241 TempRegister());
1242 } 1242 }
1243 1243
1244 1244
1245 LInstruction* LChunkBuilder::DoCompareNumericAndBranch( 1245 LInstruction* LChunkBuilder::DoCompareNumericAndBranch(
1246 HCompareNumericAndBranch* instr) { 1246 HCompareNumericAndBranch* instr) {
1247 Representation r = instr->representation(); 1247 Representation r = instr->representation();
1248 1248
1249 // TODO(all): This instruction has been replaced by HCompareNumericAndBranch
1250 // on bleeding_edge. We should update when we'll do the rebase.
1251 if (r.IsSmiOrInteger32()) { 1249 if (r.IsSmiOrInteger32()) {
1252 ASSERT(instr->left()->representation().Equals(r)); 1250 ASSERT(instr->left()->representation().Equals(r));
1253 ASSERT(instr->right()->representation().Equals(r)); 1251 ASSERT(instr->right()->representation().Equals(r));
1254 LOperand* left = UseRegisterOrConstantAtStart(instr->left()); 1252 LOperand* left = UseRegisterOrConstantAtStart(instr->left());
1255 LOperand* right = UseRegisterOrConstantAtStart(instr->right()); 1253 LOperand* right = UseRegisterOrConstantAtStart(instr->right());
1256 return new(zone()) LCompareNumericAndBranch(left, right); 1254 return new(zone()) LCompareNumericAndBranch(left, right);
1257 } else { 1255 } else {
1258 ASSERT(r.IsDouble()); 1256 ASSERT(r.IsDouble());
1259 ASSERT(instr->left()->representation().IsDouble()); 1257 ASSERT(instr->left()->representation().IsDouble());
1260 ASSERT(instr->right()->representation().IsDouble()); 1258 ASSERT(instr->right()->representation().IsDouble());
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
2442 2440
2443 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2441 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2444 LOperand* receiver = UseRegister(instr->receiver()); 2442 LOperand* receiver = UseRegister(instr->receiver());
2445 LOperand* function = UseRegister(instr->function()); 2443 LOperand* function = UseRegister(instr->function());
2446 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function); 2444 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function);
2447 return AssignEnvironment(DefineAsRegister(result)); 2445 return AssignEnvironment(DefineAsRegister(result));
2448 } 2446 }
2449 2447
2450 2448
2451 } } // namespace v8::internal 2449 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/a64/code-stubs-a64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698