Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 173773002: A64: Remove a couple of already addressed TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/lithium-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1866 matching lines...) Expand 10 before | Expand all | Expand 10 after
1877 // Invoke the function by calling through the JS entry trampoline builtin. 1877 // Invoke the function by calling through the JS entry trampoline builtin.
1878 // Notice that we cannot store a reference to the trampoline code directly in 1878 // Notice that we cannot store a reference to the trampoline code directly in
1879 // this stub, because runtime stubs are not traversed when doing GC. 1879 // this stub, because runtime stubs are not traversed when doing GC.
1880 1880
1881 // Expected registers by Builtins::JSEntryTrampoline 1881 // Expected registers by Builtins::JSEntryTrampoline
1882 // x0: code entry. 1882 // x0: code entry.
1883 // x1: function. 1883 // x1: function.
1884 // x2: receiver. 1884 // x2: receiver.
1885 // x3: argc. 1885 // x3: argc.
1886 // x4: argv. 1886 // x4: argv.
1887 // TODO(jbramley): The latest ARM code checks is_construct and conditionally
1888 // uses construct_entry. We probably need to do the same here.
1889 ExternalReference entry(is_construct ? Builtins::kJSConstructEntryTrampoline 1887 ExternalReference entry(is_construct ? Builtins::kJSConstructEntryTrampoline
1890 : Builtins::kJSEntryTrampoline, 1888 : Builtins::kJSEntryTrampoline,
1891 isolate); 1889 isolate);
1892 __ Mov(x10, Operand(entry)); 1890 __ Mov(x10, Operand(entry));
1893 1891
1894 // Call the JSEntryTrampoline. 1892 // Call the JSEntryTrampoline.
1895 __ Ldr(x11, MemOperand(x10)); // Dereference the address. 1893 __ Ldr(x11, MemOperand(x10)); // Dereference the address.
1896 __ Add(x12, x11, Code::kHeaderSize - kHeapObjectTag); 1894 __ Add(x12, x11, Code::kHeaderSize - kHeapObjectTag);
1897 __ Blr(x12); 1895 __ Blr(x12);
1898 1896
(...skipping 3900 matching lines...) Expand 10 before | Expand all | Expand 10 after
5799 MemOperand(fp, 6 * kPointerSize), 5797 MemOperand(fp, 6 * kPointerSize),
5800 NULL); 5798 NULL);
5801 } 5799 }
5802 5800
5803 5801
5804 #undef __ 5802 #undef __
5805 5803
5806 } } // namespace v8::internal 5804 } } // namespace v8::internal
5807 5805
5808 #endif // V8_TARGET_ARCH_A64 5806 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/lithium-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698