Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: pkg/analyzer/lib/src/context/source.dart

Issue 1737693004: Update SOURCE_KIND when a missing source file appears (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/context/source.dart
diff --git a/pkg/analyzer/lib/src/context/source.dart b/pkg/analyzer/lib/src/context/source.dart
index faf8eaab12890fa547a34665afbe3b9d69ee44ea..659b2ab90858a663087e0a50d4e8a673b69d8677 100644
--- a/pkg/analyzer/lib/src/context/source.dart
+++ b/pkg/analyzer/lib/src/context/source.dart
@@ -259,7 +259,11 @@ class SourceFactoryImpl implements SourceFactory {
/**
* Return a source object representing the URI that results from resolving
* the given (possibly relative) contained URI against the URI associated
- * with an existing source object, or `null` if the URI could not be resolved.
+ * with an existing source object.
+ *
+ * Returns null if no resolver can handle the URI. If the source file is
Brian Wilkerson 2016/02/26 15:07:32 nit: "Returns null" --> "Return `null`"
skybrian 2016/02/26 18:09:01 Okay, but FYI this is the opposite of normal dartd
Brian Wilkerson 2016/02/26 18:35:57 I'm aware, but it's consistent with most of the re
+ * missing, returns a non-null Source that will have a negative
Brian Wilkerson 2016/02/26 15:07:32 nit: "returns" --> "return"
+ * modificationStamp.
*
* @param containingSource the source containing the given URI
* @param containedUri the (possibly relative) URI to be resolved against the

Powered by Google App Engine
This is Rietveld 408576698