Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1737693003: - Remove Isolate::Flags structure and store flags directly in isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 1072 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 INC_STAT(Thread::Current(), 1083 INC_STAT(Thread::Current(),
1084 total_code_size, 1084 total_code_size,
1085 targets.Length() * sizeof(uword)); 1085 targets.Length() * sizeof(uword));
1086 } 1086 }
1087 1087
1088 1088
1089 // Returns 'true' if regular code generation should be skipped. 1089 // Returns 'true' if regular code generation should be skipped.
1090 bool FlowGraphCompiler::TryIntrinsify() { 1090 bool FlowGraphCompiler::TryIntrinsify() {
1091 // Intrinsification skips arguments checks, therefore disable if in checked 1091 // Intrinsification skips arguments checks, therefore disable if in checked
1092 // mode. 1092 // mode.
1093 if (FLAG_intrinsify && !isolate()->flags().type_checks()) { 1093 if (FLAG_intrinsify && !isolate()->type_checks()) {
1094 if (parsed_function().function().kind() == RawFunction::kImplicitGetter) { 1094 if (parsed_function().function().kind() == RawFunction::kImplicitGetter) {
1095 // An implicit getter must have a specific AST structure. 1095 // An implicit getter must have a specific AST structure.
1096 const SequenceNode& sequence_node = *parsed_function().node_sequence(); 1096 const SequenceNode& sequence_node = *parsed_function().node_sequence();
1097 ASSERT(sequence_node.length() == 1); 1097 ASSERT(sequence_node.length() == 1);
1098 ASSERT(sequence_node.NodeAt(0)->IsReturnNode()); 1098 ASSERT(sequence_node.NodeAt(0)->IsReturnNode());
1099 const ReturnNode& return_node = *sequence_node.NodeAt(0)->AsReturnNode(); 1099 const ReturnNode& return_node = *sequence_node.NodeAt(0)->AsReturnNode();
1100 ASSERT(return_node.value()->IsLoadInstanceFieldNode()); 1100 ASSERT(return_node.value()->IsLoadInstanceFieldNode());
1101 const LoadInstanceFieldNode& load_node = 1101 const LoadInstanceFieldNode& load_node =
1102 *return_node.value()->AsLoadInstanceFieldNode(); 1102 *return_node.value()->AsLoadInstanceFieldNode();
1103 // Only intrinsify getter if the field cannot contain a mutable double. 1103 // Only intrinsify getter if the field cannot contain a mutable double.
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
1895 1895
1896 1896
1897 void FlowGraphCompiler::FrameStateClear() { 1897 void FlowGraphCompiler::FrameStateClear() {
1898 ASSERT(!is_optimizing()); 1898 ASSERT(!is_optimizing());
1899 frame_state_.TruncateTo(0); 1899 frame_state_.TruncateTo(0);
1900 } 1900 }
1901 #endif 1901 #endif
1902 1902
1903 1903
1904 } // namespace dart 1904 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698