chrome/renderer/chrome_content_renderer_client.cc - Issue 1737693002: Allow command-line arguments to override EF public key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1737693002: Allow command-line arguments to override EF public key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix use-after-free due to StringPiece shared state Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/origin_trials/origin_trial_controller_unittest.cc ('K') | « chrome/common/chrome_switches.cc ('k') | chrome/renderer/origin_trials/origin_trial_key_manager.h » ('j') | chrome/renderer/origin_trials/origin_trial_key_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 8486b3e32a9ecd378e4e8539b82923287aa919ac..cdd2ba479905b9a718c535d618177326bf915c68 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -316,6 +316,11 @@ ChromeContentRendererClient::ChromeContentRendererClient()

#if defined(ENABLE_PRINTING)

printing::SetAgent(GetUserAgent());

#endif

+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

+ if (command_line->HasSwitch(switches::kOriginTrialPublicKey)) {

+ origin_trial_key_manager_.SetPublicKeyFromASCIIString(

+ command_line->GetSwitchValueASCII(switches::kOriginTrialPublicKey));

+ }

}

ChromeContentRendererClient::~ChromeContentRendererClient() {