Allow command-line arguments to override EF public key

chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/origin_trials/origin_trial_key_manager.h"
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/string_piece.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+const uint8_t kTestPublicKey[] = {
+    0x75, 0x10, 0xac, 0xf9, 0x3a, 0x1c, 0xb8, 0xa9, 0x28, 0x70, 0xd2,
+    0x9a, 0xd0, 0x0b, 0x59, 0xe1, 0xac, 0x2b, 0xb7, 0xd5, 0xca, 0x1f,
+    0x64, 0x90, 0x08, 0x8e, 0xa8, 0xe0, 0x56, 0x3a, 0x04, 0xd0,
+};
+
+// Base64 encoding of the above sample public key
+const char kTestPublicKeyString[] =
+    "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=";
+const char kBadEncodingPublicKeyString[] = "Not even base64!";
+// Base64-encoded, 31 bytes long
+const char kTooShortPublicKeyString[] =
+    "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BN==";
+// Base64-encoded, 33 bytes long
+const char kTooLongPublicKeyString[] =
+    "dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNAA";
+
+class OriginTrialKeyManagerTest : public testing::Test {
+ protected:
+  OriginTrialKeyManagerTest()
+      : manager_(make_scoped_ptr(new OriginTrialKeyManager())),
+        default_key_(manager_->GetPublicKey()),
+        test_key_(
+            base::StringPiece(reinterpret_cast<const char*>(kTestPublicKey),
+                              arraysize(kTestPublicKey))) {}
+  OriginTrialKeyManager* manager() { return manager_.get(); }
+  base::StringPiece default_key() { return default_key_; }
+  base::StringPiece test_key() { return test_key_; }
+
+ private:
+  scoped_ptr<OriginTrialKeyManager> manager_;
+  base::StringPiece default_key_;
+  base::StringPiece test_key_;
+};
+
+TEST_F(OriginTrialKeyManagerTest, DefaultConstructor) {
+  // We don't specify here what the key should be, but make sure that it is
+  // returned, is valid, and is consistent.
+  base::StringPiece key = manager()->GetPublicKey();
+  EXPECT_EQ(32UL, key.size());
+  EXPECT_EQ(default_key(), key);
+}
+
+TEST_F(OriginTrialKeyManagerTest, DefaultKeyIsConsistent) {
+  OriginTrialKeyManager manager2;
+  EXPECT_EQ(manager()->GetPublicKey(), manager2.GetPublicKey());
+}
+
+TEST_F(OriginTrialKeyManagerTest, OverridePublicKey) {
+  EXPECT_TRUE(manager()->SetPublicKeyFromASCIIString(kTestPublicKeyString));
+  EXPECT_NE(default_key(), manager()->GetPublicKey());
+  EXPECT_EQ(test_key(), manager()->GetPublicKey());
+  // EXPECT_EQ(...)

[chasej, 2016/02/26 06:10:34]

Was this comment supposed to be another check? Should be cleaned up.

[iclelland, 2016/02/26 15:24:47]

Was supposed to be the line above it. Fixed, thanks.

+}
+
+TEST_F(OriginTrialKeyManagerTest, OverrideKeyNotBase64) {
+  EXPECT_FALSE(
+      manager()->SetPublicKeyFromASCIIString(kBadEncodingPublicKeyString));
+  EXPECT_EQ(default_key(), manager()->GetPublicKey());
+}
+
+TEST_F(OriginTrialKeyManagerTest, OverrideKeyTooShort) {
+  EXPECT_FALSE(
+      manager()->SetPublicKeyFromASCIIString(kTooShortPublicKeyString));
+  EXPECT_EQ(default_key(), manager()->GetPublicKey());
+}
+
+TEST_F(OriginTrialKeyManagerTest, OverrideKeyTooLong) {
+  EXPECT_FALSE(manager()->SetPublicKeyFromASCIIString(kTooLongPublicKeyString));
+  EXPECT_EQ(default_key(), manager()->GetPublicKey());
+}