Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1737633002: [Interpreter] Use FastCloneRegExpStub for CreateRegExpLiteral. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Use FastCloneRegExpStub for CreateRegExpLiteral. No need to go to the runtime to create a RegExp literal in Ignition, the stub can handle everything. R=rmcilroy@chromium.org Committed: https://crrev.com/19bad8a9f131110d29517422105b9b244eca21ed Cr-Commit-Position: refs/heads/master@{#34292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/interpreter/interpreter.cc View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-25 12:55:39 UTC) #1
Benedikt Meurer
Hey Ross, Next one, using FastCloneRegExpStub always. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-25 12:56:29 UTC) #2
rmcilroy
LGTM, thanks.
4 years, 10 months ago (2016-02-25 13:30:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1737633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1737633002/1
4 years, 10 months ago (2016-02-25 13:30:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 13:32:25 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 13:33:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19bad8a9f131110d29517422105b9b244eca21ed
Cr-Commit-Position: refs/heads/master@{#34292}

Powered by Google App Engine
This is Rietveld 408576698