Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 173763002: DevTools: hide page overlay layers in LayerTreeAgent (Closed)

Created:
6 years, 10 months ago by caseq
Modified:
6 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, malch
Visibility:
Public.

Description

DevTools: hide page overlay layers in LayerTreeAgent Filter out layers that are used by page overlays when reporting layer tree to the front-end. Drive-by: move layer tests to inspector/layers. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167677

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed stray watchdog from test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -458 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/inspector/layer-compositing-reasons.html View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/inspector/layer-compositing-reasons-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/inspector/layer-tree-model.html View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/inspector/layer-tree-model-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/inspector/layers-panel-mouse-events.html View 1 chunk +0 lines, -166 lines 0 comments Download
D LayoutTests/inspector/layers-panel-mouse-events-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
A + LayoutTests/inspector/layers/layer-compositing-reasons.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/layers/layer-compositing-reasons-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/layers/layer-tree-model.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/layers/layer-tree-model-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/layers/layers-panel-mouse-events.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/layers/layers-panel-mouse-events-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/inspector/layers/no-overlay-layers.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/inspector/layers/no-overlay-layers-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/layers/resources/composited-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/inspector/resources/composited-iframe.html View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 4 chunks +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 3 chunks +16 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 3 chunks +26 lines, -10 lines 0 comments Download
M Source/web/PageOverlay.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
6 years, 10 months ago (2014-02-20 13:44:29 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/173763002/diff/1/LayoutTests/inspector/layers/no-overlay-layers.html File LayoutTests/inspector/layers/no-overlay-layers.html (right): https://codereview.chromium.org/173763002/diff/1/LayoutTests/inspector/layers/no-overlay-layers.html#newcode21 LayoutTests/inspector/layers/no-overlay-layers.html:21: setTimeout(InspectorTest.completeTest.bind(InspectorTest), 3000); Please remove.
6 years, 10 months ago (2014-02-20 15:47:21 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 10 months ago (2014-02-24 06:26:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/173763002/60001
6 years, 10 months ago (2014-02-24 06:26:57 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 11:56:56 UTC) #5
Message was sent while issue was closed. 
Change committed as 167677

Powered by Google App Engine
This is Rietveld 408576698