Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: Source/bindings/scripts/generate-bindings.pl

Issue 17376006: Implement WebIDL implements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add back [PerWorldBindings] Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/preprocess_idls.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/generate-bindings.pl
diff --git a/Source/bindings/scripts/generate-bindings.pl b/Source/bindings/scripts/generate-bindings.pl
index a03e39542abae8b69fd43038d23cfc4e7550d1b1..4be15c16d8132447f77b7d6415b5ffae8db47f9c 100755
--- a/Source/bindings/scripts/generate-bindings.pl
+++ b/Source/bindings/scripts/generate-bindings.pl
@@ -134,7 +134,7 @@ foreach my $idlFile (@supplementedIdlFiles) {
my $document = $parser->Parse($idlFile, $defines, $preprocessor);
foreach my $interface (@{$document->interfaces}) {
- if ($interface->isPartial and $interface->name eq $targetInterfaceName) {
+ if (!$interface->isPartial || $interface->name eq $targetInterfaceName) {
my $targetDataNode;
foreach my $interface (@{$targetDocument->interfaces}) {
if ($interface->name eq $targetInterfaceName) {
@@ -147,7 +147,7 @@ foreach my $idlFile (@supplementedIdlFiles) {
# Support for attributes of partial interfaces.
foreach my $attribute (@{$interface->attributes}) {
# Record that this attribute is implemented by $interfaceName.
- $attribute->extendedAttributes->{"ImplementedBy"} = $interfaceName;
+ $attribute->extendedAttributes->{"ImplementedBy"} = $interfaceName if $interface->isPartial;
# Add interface-wide extended attributes to each attribute.
applyInterfaceExtendedAttributes($interface, $attribute->extendedAttributes);
@@ -158,7 +158,7 @@ foreach my $idlFile (@supplementedIdlFiles) {
# Support for methods of partial interfaces.
foreach my $function (@{$interface->functions}) {
# Record that this method is implemented by $interfaceName.
- $function->extendedAttributes->{"ImplementedBy"} = $interfaceName;
+ $function->extendedAttributes->{"ImplementedBy"} = $interfaceName if $interface->isPartial;
# Add interface-wide extended attributes to each method.
applyInterfaceExtendedAttributes($interface, $function->extendedAttributes);
@@ -169,7 +169,7 @@ foreach my $idlFile (@supplementedIdlFiles) {
# Support for constants of partial interfaces.
foreach my $constant (@{$interface->constants}) {
# Record that this constant is implemented by $interfaceName.
- $constant->extendedAttributes->{"ImplementedBy"} = $interfaceName;
+ $constant->extendedAttributes->{"ImplementedBy"} = $interfaceName if $interface->isPartial;
# Add interface-wide extended attributes to each constant.
applyInterfaceExtendedAttributes($interface, $constant->extendedAttributes);
« no previous file with comments | « no previous file | Source/bindings/scripts/preprocess_idls.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698