Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1737593006: Re-land "Replace CPDF_Rect and CPDF_Point with CFX types." (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land "Replace CPDF_Rect and CPDF_Point with CFX types." TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/281a9eadff15b167e2ee3032e21b83190ad49125

Patch Set 1 : Original patch #

Patch Set 2 : Ooops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1625 lines, -1552 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +1 line, -18 lines 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 6 chunks +11 lines, -10 lines 0 comments Download
M core/include/fpdftext/fpdf_text.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_coordinates.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 5 chunks +19 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 13 chunks +39 lines, -37 lines 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 6 chunks +30 lines, -28 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/text_int.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_CheckBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 5 chunks +24 lines, -21 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 2 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_RadioButton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 12 chunks +47 lines, -47 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 12 chunks +34 lines, -33 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 11 chunks +27 lines, -27 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 14 chunks +49 lines, -47 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Caret.h View 2 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 5 chunks +16 lines, -15 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 6 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 4 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 3 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 8 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 3 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 10 chunks +78 lines, -74 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 7 chunks +31 lines, -30 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CheckBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 15 chunks +42 lines, -42 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_RadioButton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 11 chunks +21 lines, -21 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 28 chunks +49 lines, -45 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 25 chunks +42 lines, -41 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform_embeddertest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 11 chunks +20 lines, -17 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_ap.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 21 chunks +73 lines, -69 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 14 chunks +45 lines, -43 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 31 chunks +55 lines, -55 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Field.h View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Button.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Caret.cpp View 6 chunks +16 lines, -15 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 12 chunks +34 lines, -31 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 23 chunks +39 lines, -36 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 15 chunks +28 lines, -23 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_IconList.cpp View 12 chunks +21 lines, -20 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 11 chunks +22 lines, -21 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp View 7 chunks +30 lines, -29 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 36 chunks +63 lines, -60 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ScrollBar.cpp View 38 chunks +162 lines, -142 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Signature.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_SpecialButton.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 72 chunks +178 lines, -173 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 14 chunks +47 lines, -43 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, dif #2 vs. #1.
4 years, 10 months ago (2016-02-26 21:27:41 UTC) #2
Tom Sepez
Making TBR, 2-char difference between previous LGTM'd patch.
4 years, 10 months ago (2016-02-26 22:23:58 UTC) #4
Tom Sepez
Committed patchset #2 (id:20001) manually as 281a9eadff15b167e2ee3032e21b83190ad49125 (presubmit successful).
4 years, 10 months ago (2016-02-26 22:24:33 UTC) #6
Lei Zhang
4 years, 10 months ago (2016-02-26 22:40:34 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698