ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc - Issue 1737563003: [NTP Snippets] Persist the set of snippets in a pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

Issue 1737563003: [NTP Snippets] Persist the set of snippets in a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_merge

Patch Set: noyau review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

index 319d1f898c4a47b1d9c3380645bb475190a1c34f..954a3b3b8d76189c746f94e14f4d9710b3d9ec37 100644

--- a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

@@ -62,7 +62,8 @@ IOSChromeNTPSnippetsServiceFactory::BuildServiceInstanceFor(

base::SequencedWorkerPool::GetSequenceToken(),

base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);

return make_scoped_ptr(new ntp_snippets::NTPSnippetsService(

- task_runner, GetApplicationContext()->GetApplicationLocale(), scheduler,

+ chrome_browser_state->GetPrefs(), task_runner,

+ GetApplicationContext()->GetApplicationLocale(), scheduler,

make_scoped_ptr(new ntp_snippets::NTPSnippetsFetcher(

task_runner, (SigninManagerBase*)signin_manager, token_service,

request_context, browser_state->GetStatePath()))));

« no previous file with comments | « components/ntp_snippets/pref_names.cc ('k') | ios/chrome/browser/prefs/browser_prefs.mm » ('j') | no next file with comments »