Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: components/ntp_snippets/ntp_snippets_service_unittest.cc

Issue 1737563003: [NTP Snippets] Persist the set of snippets in a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets_merge
Patch Set: noyau review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.cc ('k') | components/ntp_snippets/pref_names.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/thread_task_runner_handle.h" 7 #include "base/thread_task_runner_handle.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "components/ntp_snippets/ntp_snippet.h" 9 #include "components/ntp_snippets/ntp_snippet.h"
10 #include "components/ntp_snippets/ntp_snippets_fetcher.h" 10 #include "components/ntp_snippets/ntp_snippets_fetcher.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 scoped_ptr<NTPSnippetsService> CreateSnippetService() { 53 scoped_ptr<NTPSnippetsService> CreateSnippetService() {
54 scoped_refptr<base::SingleThreadTaskRunner> task_runner( 54 scoped_refptr<base::SingleThreadTaskRunner> task_runner(
55 base::ThreadTaskRunnerHandle::Get()); 55 base::ThreadTaskRunnerHandle::Get());
56 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter = 56 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter =
57 new net::TestURLRequestContextGetter(task_runner.get()); 57 new net::TestURLRequestContextGetter(task_runner.get());
58 FakeProfileOAuth2TokenService* token_service = 58 FakeProfileOAuth2TokenService* token_service =
59 new FakeProfileOAuth2TokenService(); 59 new FakeProfileOAuth2TokenService();
60 FakeSigninManagerBase* signin_manager = new FakeSigninManagerBase( 60 FakeSigninManagerBase* signin_manager = new FakeSigninManagerBase(
61 signin_client_.get(), account_tracker_.get()); 61 signin_client_.get(), account_tracker_.get());
62 62
63 scoped_ptr<NTPSnippetsService> service( 63 scoped_ptr<NTPSnippetsService> service(new NTPSnippetsService(
64 new NTPSnippetsService(task_runner.get(), std::string("fr"), nullptr, 64 nullptr, task_runner.get(), std::string("fr"), nullptr,
65 make_scoped_ptr(new NTPSnippetsFetcher(task_runner.get(), 65 make_scoped_ptr(new NTPSnippetsFetcher(
66 signin_manager, token_service, request_context_getter, 66 task_runner.get(), signin_manager, token_service,
67 base::FilePath())))); 67 request_context_getter, base::FilePath()))));
68 return service; 68 return service;
69 } 69 }
70 70
71 private: 71 private:
72 scoped_ptr<AccountTrackerService> account_tracker_; 72 scoped_ptr<AccountTrackerService> account_tracker_;
73 scoped_ptr<TestSigninClient> signin_client_; 73 scoped_ptr<TestSigninClient> signin_client_;
74 base::MessageLoop message_loop_; 74 base::MessageLoop message_loop_;
75 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsServiceTest); 75 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsServiceTest);
76 }; 76 };
77 77
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 EXPECT_TRUE(service->LoadFromJSONString(json_str)); 164 EXPECT_TRUE(service->LoadFromJSONString(json_str));
165 165
166 SnippetObserver observer; 166 SnippetObserver observer;
167 service->AddObserver(&observer); 167 service->AddObserver(&observer);
168 168
169 EXPECT_TRUE(observer.loaded_); 169 EXPECT_TRUE(observer.loaded_);
170 170
171 service->RemoveObserver(&observer); 171 service->RemoveObserver(&observer);
172 } 172 }
173 } // namespace ntp_snippets 173 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/ntp_snippets_service.cc ('k') | components/ntp_snippets/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698