Use SkPicture's InstallPixelRefProc to decode SkImages in an skp

Use SkPicture's InstallPixelRefProc to decode SkImages in an skp

If the InstallPixelRefProc is NULL, we fall back on SkImageGenerator.
This should fix tools/get_images_from_skps.cpp.

BUG=skia:5005
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737543002

[msarett, 2016-02-24 23:10:01]

Description was changed from

==========
Use SkPicture's InstallPixelRefProc to decode SkImages in an skp

If the InstallPixelRefProc is NULL, we fall back on SkImageGenerator.
This should fix tools/get_images_from_skps.cpp.

BUG=skia:5005
==========

to

==========
Use SkPicture's InstallPixelRefProc to decode SkImages in an skp

If the InstallPixelRefProc is NULL, we fall back on SkImageGenerator.
This should fix tools/get_images_from_skps.cpp.

BUG=skia:5005
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-24 23:30:53]

msarett@google.com changed reviewers:
+ mtklein@google.com, reed@google.com, scroggo@google.com

[msarett, 2016-02-24 23:30:54]

https://codereview.chromium.org/1737543002/diff/1/src/core/SkReadBuffer.cpp
File src/core/SkReadBuffer.cpp (right):

https://codereview.chromium.org/1737543002/diff/1/src/core/SkReadBuffer.cpp#n...
src/core/SkReadBuffer.cpp:290: SkImage* image = SkImage::NewFromBitmap(bitmap);
This is the quick and easy fix for tools/get_images_from_skps.cpp.

But I'm not sure it's the right fix if we have clients that use this to hook in
their own decoder (and expect to decode efficiently).  SkImage::NewFromBitmap()
may perform a copy.

An alternative is to change the signature of the InstallPixelRefProc to output
memory/SkData and an SkImageInfo.

[scroggo, 2016-02-25 12:52:36]

https://codereview.chromium.org/1737543002/diff/1/src/core/SkReadBuffer.cpp
File src/core/SkReadBuffer.cpp (right):

https://codereview.chromium.org/1737543002/diff/1/src/core/SkReadBuffer.cpp#n...
src/core/SkReadBuffer.cpp:290: SkImage* image = SkImage::NewFromBitmap(bitmap);
On 2016/02/24 23:30:54, msarett wrote:
> This is the quick and easy fix for tools/get_images_from_skps.cpp.
> 
> But I'm not sure it's the right fix if we have clients that use this to hook
in
> their own decoder (and expect to decode efficiently). 
SkImage::NewFromBitmap()
> may perform a copy.
> 
> An alternative is to change the signature of the InstallPixelRefProc to output
> memory/SkData and an SkImageInfo.

My preference is to replace InstallPixelRefProc, as I have done in
crrev.com/1717663002. Please take a look at that one.

[msarett, 2016-02-25 13:47:07]

SGTM

[msarett, 2016-02-25 14:22:49]

Description was changed from

==========
Use SkPicture's InstallPixelRefProc to decode SkImages in an skp

If the InstallPixelRefProc is NULL, we fall back on SkImageGenerator.
This should fix tools/get_images_from_skps.cpp.

BUG=skia:5005
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use SkPicture's InstallPixelRefProc to decode SkImages in an skp

If the InstallPixelRefProc is NULL, we fall back on SkImageGenerator.
This should fix tools/get_images_from_skps.cpp.

BUG=skia:5005
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========