Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 1737453004: CL for perf tryjob on linux Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | tools/run-perf-test.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index 360938dc66080320085f0e3bb87ab25ab82713f2..1345ef47290de62c0a38830129f8490a1c712f14 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -570,8 +570,10 @@ bool ThreadState::shouldScheduleV8FollowupGC()
bool ThreadState::shouldSchedulePageNavigationGC(float estimatedRemovalRatio)
{
- // TODO(keishi): Temporarily disabled to observe impact. crbug.com/588029
- return false;
+ // If estimatedRemovalRatio is low we should let IdleGC handle this.
+ if (estimatedRemovalRatio < 0.01)
+ return false;
+ return judgeGCThreshold(32 * 1024 * 1024, 1.5 * (1 - estimatedRemovalRatio));
}
bool ThreadState::shouldForceConservativeGC()
@@ -668,7 +670,6 @@ void ThreadState::schedulePageNavigationGCIfNeeded(float estimatedRemovalRatio)
dataLogF("Scheduled PageNavigationGC\n");
#endif
schedulePageNavigationGC();
- return;
}
}
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | tools/run-perf-test.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698