Issue 1737453002: WIP: snap-width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1737453002: WIP: snap-width

Created:
4 years, 10 months ago by kojii

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

WIP: snap-width BUG=

Patch Set 1 #

Patch Set 2 : Fix alignment issue #

Patch Set 3 : Make ComputedStyle smaller by clamping to 255 #

Patch Set 4 : Fix #

Patch Set 5 : availableLogicalWidth #

Patch Set 6 : Removed the max-width option, available-width works better #

Patch Set 7 : rebase #

Patch Set 8 : Rebase #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -25 lines)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -7 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/imported/csswg-test/css-snap-size-1/snap-width-parsing-001-expected.txt	View	1 2 3	1 chunk	+0 lines, -13 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/CSSProperties.in	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 2 3 4 5 6 7	1 chunk	+20 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/UseCounter.cpp	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutBox.h	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutBox.cpp	View	1 2 3 4 5 6 7	1 chunk	+13 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/ComputedStyle.h	View	1 2 3 4 5 6 7	2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/ComputedStyle.cpp	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp	View	1 2 3 4 5 6 7	4 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/LayoutUnit.h	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -0 lines	0 comments	Download