third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/device-orientation-success.html ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h

index be4639cd85446d019097585013801e694a0b09a8..347d02ca7983373e7d7457015bf94e3fdaa6b52e 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.h

@@ -36,7 +36,7 @@ class WebDeviceOrientationData;

class DeviceOrientationData final : public GarbageCollected<DeviceOrientationData> {

public:

static DeviceOrientationData* create();

- static DeviceOrientationData* create(const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute = false);

+ static DeviceOrientationData* create(const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, bool absolute);

static DeviceOrientationData* create(const WebDeviceOrientationData&);

DEFINE_INLINE_TRACE() { }

@@ -47,18 +47,17 @@ public:

bool canProvideAlpha() const;

bool canProvideBeta() const;

bool canProvideGamma() const;

- bool canProvideAbsolute() const;

bool canProvideEventData() const;

private:

DeviceOrientationData();

- DeviceOrientationData(const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute);

+ DeviceOrientationData(const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, bool absolute);

Nullable<double> m_alpha;

Nullable<double> m_beta;

Nullable<double> m_gamma;

- Nullable<bool> m_absolute;

+ bool m_absolute;

};

} // namespace blink