third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/null-values.html ('k') | third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html b/third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html

index 25141c2eb6a47db3d30d8baf54322aea4eabd2cf..5a4c9444d9431179c14be10f2d3f6b2c5a4cdcc5 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html

@@ -11,12 +11,13 @@ evalAndLog("event = document.createEvent('DeviceOrientationEvent')");

shouldBeTrue("event.alpha == null");

shouldBeTrue("event.beta == null");

shouldBeTrue("event.gamma == null");

-shouldBeTrue("event.absolute == null");

+shouldBeFalse("event.absolute");

-evalAndLog("event.initDeviceOrientationEvent('', false, false, 0, 1, 2)");

+evalAndLog("event.initDeviceOrientationEvent('', false, false, 0, 1, 2, false)");

shouldBeTrue("event.alpha == 0");

shouldBeTrue("event.beta == 1");

shouldBeTrue("event.gamma == 2");

+shouldBeFalse("event.absolute");

evalAndLog("event.initDeviceOrientationEvent('', false, false, 0, 1, 2, true)");

shouldBeTrue("event.alpha == 0");

@@ -28,26 +29,31 @@ evalAndLog("event.initDeviceOrientationEvent()");

shouldBeTrue("event.alpha == null");

shouldBeTrue("event.beta == null");

shouldBeTrue("event.gamma == null");

+shouldBeFalse("event.absolute");

-evalAndLog("event.initDeviceOrientationEvent('', false, false, [], [], [])");

+evalAndLog("event.initDeviceOrientationEvent('', false, false, [], [], [], [])");

shouldBeTrue("event.alpha == 0");

shouldBeTrue("event.beta == 0");

shouldBeTrue("event.gamma == 0");

+shouldBeTrue("event.absolute");

-evalAndLog("event.initDeviceOrientationEvent('', false, false, undefined, undefined, undefined)");

+evalAndLog("event.initDeviceOrientationEvent('', false, false, undefined, undefined, undefined, undefined)");

shouldBeTrue("event.alpha == null");

shouldBeTrue("event.beta == null");

shouldBeTrue("event.gamma == null");

+shouldBeFalse("event.absolute");

-evalAndLog("event.initDeviceOrientationEvent('', false, false, '', '', '')");

+evalAndLog("event.initDeviceOrientationEvent('', false, false, '', '', '', '')");

shouldBeTrue("event.alpha == 0");

shouldBeTrue("event.beta == 0");

shouldBeTrue("event.gamma == 0");

+shouldBeFalse("event.absolute");

-evalAndLog("event.initDeviceOrientationEvent('', false, false, null, null, null)");

+evalAndLog("event.initDeviceOrientationEvent('', false, false, null, null, null, null)");

shouldBeTrue("event.alpha == null");

shouldBeTrue("event.beta == null");

shouldBeTrue("event.gamma == null");

+shouldBeFalse("event.absolute");

</script>

</body>

</html>