content/browser/device_sensors/sensor_manager_android.cc - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/sensor_manager_android.cc

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/data_fetcher_shared_memory_win.cc ('k') | content/browser/device_sensors/sensor_manager_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/sensor_manager_android.cc

diff --git a/content/browser/device_sensors/sensor_manager_android.cc b/content/browser/device_sensors/sensor_manager_android.cc

index e821fb445a42b30e5c07d209750872de9035dbb8..5fffdd9072015cd368d9d498c5f592330c77a3ad 100644

--- a/content/browser/device_sensors/sensor_manager_android.cc

+++ b/content/browser/device_sensors/sensor_manager_android.cc

@@ -41,7 +41,6 @@ void SetOrientationBufferStatus(

bool ready, bool absolute) {

buffer->seqlock.WriteBegin();

buffer->data.absolute = absolute;

- buffer->data.hasAbsolute = ready;

buffer->data.allAvailableSensorsAreActive = ready;

buffer->seqlock.WriteEnd();

}