Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: components/test_runner/test_runner.cc

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index d78c862055811f4ed56d66c5103a7b98eb68bf6d..836924e40601d3d6fc8e05e9f7c17d991372008f 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -988,7 +988,6 @@ void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) {
double beta = 0.0;
bool has_gamma = false;
double gamma = 0.0;
- bool has_absolute = false;
bool absolute = false;
args->GetNext(&has_alpha);
@@ -997,13 +996,12 @@ void TestRunnerBindings::SetMockDeviceOrientation(gin::Arguments* args) {
args->GetNext(&beta);
args->GetNext(&has_gamma);
args->GetNext(&gamma);
- args->GetNext(&has_absolute);
args->GetNext(&absolute);
runner_->SetMockDeviceOrientation(has_alpha, alpha,
has_beta, beta,
has_gamma, gamma,
- has_absolute, absolute);
+ absolute);
}
void TestRunnerBindings::SetMockScreenOrientation(
@@ -2488,7 +2486,7 @@ void TestRunner::SetMockDeviceMotion(
void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha,
bool has_beta, double beta,
bool has_gamma, double gamma,
- bool has_absolute, bool absolute) {
+ bool absolute) {
WebDeviceOrientationData orientation;
// alpha
@@ -2504,7 +2502,6 @@ void TestRunner::SetMockDeviceOrientation(bool has_alpha, double alpha,
orientation.gamma = gamma;
// absolute
- orientation.hasAbsolute = has_absolute;
orientation.absolute = absolute;
delegate_->SetDeviceOrientationData(orientation);
« no previous file with comments | « components/test_runner/test_runner.h ('k') | content/browser/device_sensors/data_fetcher_shared_memory_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698