content/browser/device_sensors/sensor_manager_chromeos.cc - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/sensor_manager_chromeos.cc

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/device_sensors/sensor_manager_android.cc ('K') | « content/browser/device_sensors/sensor_manager_android.cc ('k') | content/browser/device_sensors/sensor_manager_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/sensor_manager_chromeos.cc

diff --git a/content/browser/device_sensors/sensor_manager_chromeos.cc b/content/browser/device_sensors/sensor_manager_chromeos.cc

index 97dc8fbcbc624ba5e005042398a508bd9229ebee..3544749d6e498f7ea837aacaaccaaa81b41a20b0 100644

--- a/content/browser/device_sensors/sensor_manager_chromeos.cc

+++ b/content/browser/device_sensors/sensor_manager_chromeos.cc

@@ -69,7 +69,6 @@ void SensorManagerChromeOS::StartFetchingDeviceOrientationData(

// No compass information, so we cannot provide absolute orientation.

orientation_buffer_->seqlock.WriteBegin();

orientation_buffer_->data.absolute = false;

- orientation_buffer_->data.hasAbsolute = true;

philipj_slow 2016/02/26 03:54:01 At least ChromeOS looks simple.

timvolodine 2016/03/01 22:36:25 ;)

orientation_buffer_->seqlock.WriteEnd();

if (!motion_buffer_)